[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] jihoonson commented on a change in pull request #5471: Implement force push down for nested group by query


jihoonson commented on a change in pull request #5471: Implement force push down for nested group by query
URL: https://github.com/apache/incubator-druid/pull/5471#discussion_r204897508
 
 

 ##########
 File path: processing/src/main/java/io/druid/query/groupby/epinephelinae/GroupByRowProcessor.java
 ##########
 @@ -66,18 +70,28 @@
       final GroupByQueryResource resource,
       final ObjectMapper spillMapper,
       final String processingTmpDir,
-      final int mergeBufferSize
+      final int mergeBufferSize,
+      final boolean wasQueryPushedDown
   )
   {
-    final GroupByQuery query = (GroupByQuery) queryParam;
+    GroupByQuery queryWithRenamedDimensions = null;
+    if (wasQueryPushedDown) {
+      List<DimensionSpec> newDims = new ArrayList<>(((GroupByQuery) queryParam).getDimensions().size());
 
 Review comment:
   nit: can be simpler.
   
   ```java
         final List<DimensionSpec> newDims = ((GroupByQuery) queryParam).getDimensions()
                                                                        .stream()
                                                                        .map(RenamedDimensionSpec::new)
                                                                        .collect(Collectors.toList());
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@xxxxxxxxxxxxxxxx


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxx