osdir.com

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] leventov commented on a change in pull request #5980: Various changes about druid-services module


leventov commented on a change in pull request #5980: Various changes about druid-services module
URL: https://github.com/apache/incubator-druid/pull/5980#discussion_r201368904
 
 

 ##########
 File path: services/src/main/java/io/druid/cli/CliInternalHadoopIndexer.java
 ##########
 @@ -150,7 +144,7 @@ public HadoopDruidIndexerConfig getHadoopDruidIndexerConfig()
             final URI argumentSpecUri = new URI(argumentSpec);
             final String argumentSpecScheme = argumentSpecUri.getScheme();
 
-            if (argumentSpecScheme == null || argumentSpecScheme.equals("file")) {
+            if (argumentSpecScheme == null || "file".equals(argumentSpecScheme)) {
 
 Review comment:
   Also worth catching this consistently, via IntelliJ inspection

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@xxxxxxxxxxxxxxxx


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxx