osdir.com

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] leventov commented on a change in pull request #5980: Various changes about druid-services module


leventov commented on a change in pull request #5980: Various changes about druid-services module
URL: https://github.com/apache/incubator-druid/pull/5980#discussion_r201370593
 
 

 ##########
 File path: services/src/main/java/io/druid/cli/CliPeon.java
 ##########
 @@ -243,7 +242,7 @@ public void configure(Binder binder)
             // configuration of other parameters, but I don't think that's actually a problem.
             // Note, if that is actually not a problem, then that probably means we have the wrong abstraction.
             binder.bind(SegmentLoaderConfig.class)
-                  .toInstance(new SegmentLoaderConfig().withLocations(Arrays.<StorageLocationConfig>asList()));
+                  .toInstance(new SegmentLoaderConfig().withLocations(Collections.emptyList()));
 
 Review comment:
   If you wish you could also fix all occurrences of this, via IntelliJ inspection "Too few arguments of Arrays.asList()", and prohibit it on CI level. There are hundreds of such issues in the codebase, but since there is an automatic fix in IntelliJ, it could be even not very hard to do this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@xxxxxxxxxxxxxxxx


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxx