osdir.com

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] jihoonson commented on issue #5958: Part 2 of changes for SQL Compatible Null Handling


jihoonson commented on issue #5958: Part 2 of changes for SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#issuecomment-403663044
 
 
   Some comments and questions for the PR description.
   
   > Aggrgator/BufferAggregator - Added a new method boolean isNull() which returns false by default. aggregators that support nullability can choose to override this and return true if the aggregated result is null.
   
   This should be moved to https://github.com/apache/incubator-druid/pull/5278.
   
   > Changes to Druid build-in SQL layer
   > * NULL and empty strings are treated differently.
   
   I haven't checked through the whole patch, so am wondering this is true only for the SQL layer or the entire Druid query processing system.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@xxxxxxxxxxxxxxxx


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxx