osdir.com

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [VOTE] Release Apache Commons FileUpload 1.4 based on RC1


I’m going to -1 this [VOTE] because the NOTICE.txt has 2017 as the latest date and because I’ve got some IntelliJ files in the src-zip (doh). Thanks Bruno for catching those (see below). I’m going to go with an RC2 for the sake of posterity.

Cheers,
-Rob

> On Dec 24, 2018, at 1:34 AM, Rob Tompkins <chtompki@xxxxxxxxx> wrote:
> 
> 
> 
>> On Dec 24, 2018, at 12:07 AM, Bruno P. Kinoshita <brunodepaulak@xxxxxxxxxxxx> wrote:
>> 
>> 
>> 
>> Hi Rob! (This e-mail is not CC'ing the mailing list, see issue with IntelliJ files, was writing to all, then thought it would be best to ask you first)
>> 
>> 
>> ---
>> 
>> Building OK with `mvn clean test install site` on:
>> 
>> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-18T06:33:14+12:00)
>> Maven home: /opt/apache-maven-3.5.4
>> Java version: 1.8.0_191, vendor: Oracle Corporation, runtime: /usr/lib/jvm/java-8-openjdk-amd64/jre
>> Default locale: en_NZ, platform encoding: UTF-8
>> OS name: "linux", version: "4.15.0-43-generic", arch: "amd64", family: "unix"
>> 
>> It looks like there's one new PMD issue, but minor one.
>> 
>> NOTICE says Copyright 2012-2017, but I believe this is not a blocker.
> 
> That actually feels like a blocker..whoops.. thanks for that catch.
> 
>> 
>> Had a look inside the dist area binaries, and everything looks OK. 
>> 
>> 
>> Minor nit-pick only about .iml & .idea/ (IntelliJ files I guess) inside the -src file. Is it an issue? I use PyCharm, and I believe these files store something like searched strings, opened files, etc... which **can** be dangerous to the RM if s/he searched for some password (I had a look and I think there's nothing too important in these files, but am posting this e-mail first to Rob only).
> 
> And yea….I shouldn’t have .iml and .idea files in the -src file so that would imply that I need to polish the release plugin some. I’d be willing to do an RC2 over that…let’s take this up to the dev list...yeah?? I feel like your points are solid and valuable and worth giving a -0 to a -1 over.
> 
> -Rob
> 
> 
>> 
>> 
>> Other than that, everything else looks OK. Site reports OK. Checked the signature of some binaries from Maven repository, and found no errors.
>> 
>> If someone could, please, confirm if the IDE files is a problem. If not, I'll cast my +1 vote.
>> 
>> 
>> Thanks!
>> Bruno
>> 
>> ________________________________
>> From: Rob Tompkins <chtompki@xxxxxxxxxx>
>> To: Commons Developers List <dev@xxxxxxxxxxxxxxxxxx> 
>> Sent: Monday, 24 December 2018 4:33 PM
>> Subject: [VOTE] Release Apache Commons FileUpload 1.4 based on RC1
>> 
>> 
>> 
>> We have fixed quite a few bugs and added some significant enhancements since Apache Commons FileUpload 1.3.3 was released, so I would like to release Apache Commons FileUpload 1.4.
>> 
>> 
>> Apache Commons FileUpload 1.4 RC1 is available for review here:
>> 
>>   https://dist.apache.org/repos/dist/dev/commons/fileupload/1.4-RC1 (svn revision 31671)
>> 
>> 
>> The Git tag commons-fileupload-1.4-RC1 commit for this RC is 6cc28fd2bdcda327fccb63f779aed5964f59a9c7 which you can browse here:
>> 
>>   https://github.com/apache/commons-fileupload/releases/tag/commons-fileupload-1.4-RC1
>> 
>> 
>> Maven artifacts are here:
>> 
>>   https://repository.apache.org/content/repositories/orgapachecommons-1402/org/apache/commons/commons-fileupload/1.4/
>> 
>> 
>> These are the Maven artifacts and their hashes in Nexus:
>> 
>> 
>> #Nexus SHA-1s
>> 
>> commons-fileupload-1.4.jar=f88b7989d9753d5f5d00d6c8188f99f68c72b58c
>> 
>> commons-fileupload-1.4-test-sources.jar=c889e5272f140173e270b87fd57648098fb35518
>> 
>> commons-fileupload-1.4.pom=26a35c713a9a52ea6e923524bc0ec3c737e72c22
>> 
>> commons-fileupload-1.4-tests.jar=97b3a6f617594779d9367de0ce52e85607b14424
>> 
>> commons-fileupload-1.4-sources.jar=ed23501042611e499dffc8ba7b48a4c16995fbf0
>> 
>> commons-fileupload-1.4-javadoc.jar=d6bb58c1f165b924719787fa6c180206422adfac
>> 
>> 
>> #Release SHA-256s
>> 
>> #Sun Dec 23 22:17:56 EST 2018
>> 
>> commons-fileupload-1.4-bin-tar.gz=c54349a3ba4f6f07f7b021ad34288947a8a9af13dfed4066fa0186a0b9ed1ae8
>> 
>> commons-fileupload-1.4-src-zip=f792ff16d35f3da6e213dbe4f9f9193171a84c4486a1c3e088e3e6c18a03f7b0
>> 
>> commons-fileupload-1.4-bin-zip=505ef0b4234ca17f1675bf44f7f717356b1ee092d860e1c3c91836548263a771
>> 
>> commons-fileupload-1.4-src-tar.gz=30ac1b6951648561491de928d97aac2bff9add98b811c28c67c3d56e89104e25
>> 
>> 
>> I have tested this with 'mvn clean test package site'*** using: 
>> 
>> 
>> Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T14:41:47-04:00)
>> 
>> Maven home: /usr/local/Cellar/maven/3.6.0/libexec
>> 
>> Java version: 1.8.0_191, vendor: Oracle Corporation, runtime: /Library/Java/JavaVirtualMachines/jdk1.8.0_191.jdk/Contents/Home/jre
>> 
>> Default locale: en_US, platform encoding: UTF-8
>> 
>> OS name: "mac os x", version: "10.14.1", arch: "x86_64", family: "mac"
>> 
>> 
>> 
>> Details of changes since 1.3.3 are in the release notes:
>> 
>>   https://dist.apache.org/repos/dist/dev/commons/fileupload/1.4-RC1/RELEASE-NOTES.txt
>> 
>>   https://dist.apache.org/repos/dist/dev/commons/fileupload/1.4-RC1/site/changes-report.html
>> 
>> 
>> Site:
>> 
>>   https://dist.apache.org/repos/dist/dev/commons/fileupload/1.4-RC1/site
>> 
>>   (note some *relative* links are broken and the 1.4 directories are not yet created - these will be OK once the site is deployed.)
>> 
>> 
>> CLIRR Report (compared to 1.3.3): There are 3 noteworth failures that we are aware of in the CLIRR report and are ok with.
>> 
>>   https://dist.apache.org/repos/dist/dev/commons/fileupload/1.4-RC1/site/clirr-report.html
>> 
>> 
>> 
>> RAT Report:
>> 
>>   https://dist.apache.org/repos/dist/dev/commons/fileupload/1.4-RC1/site/rat-report.html
>> 
>> 
>> KEYS:
>> 
>> https://www.apache.org/dist/commons/KEYS
>> 
>> 
>> Please review the release candidate and vote.
>> 
>> This vote will close no sooner that 72 hours from now.
>> 
>> 
>> [ ] +1 Release these artifacts
>> 
>> [ ] +0 OK, but...
>> 
>> [ ] -0 OK, but really should fix...
>> 
>> [ ] -1 I oppose this release because...
>> 
>> 
>> Thank you,
>> 
>> 
>> Rob Tompkins, 
>> 
>> Release Manager (using key B6E73D84EA4FCC47166087253FAAD2CD5ECBB314)
>> 
>> 
>> 
>> ---------------------------------------------------------------------
>> 
>> To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxxxx
>> 
>> For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxxxx