osdir.com

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Vote] Release Apache Commons RNG v1.2 (RC1)


On Thu, 6 Dec 2018 at 10:58, Gilles <gilles@xxxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Wed, 5 Dec 2018 21:29:26 -0500, Rob Tompkins wrote:
> > With:
> >
> > $ mvn -version
> > Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
> > 2018-06-17T14:33:14-04:00)
> > Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> > Java version: 9.0.4, vendor: Oracle Corporation, runtime:
> > /Library/Java/JavaVirtualMachines/jdk-9.0.4.jdk/Contents/Home
> > Default locale: en_US, platform encoding: UTF-8
> > OS name: "mac os x", version: "10.14.1", arch: "x86_64", family:
> > "mac"
> >
> > I get this:
> >
> > [ERROR] Failed to execute goal
> > org.apache.maven.plugins:maven-site-plugin:3.7.1:site (default-site)
> > on project commons-rng-sampling: Error generating
> > maven-javadoc-plugin:3.0.1:javadoc report:
> > [ERROR] Exit code: 1 -
> >
> > /Users/tompkicr/Desktop/commons-rng/source/commons-rng-1.2-src/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/SmallMeanPoissonSampler.java:35:
> > error: reference not found
> > [ERROR]  * For large means, {@link LargePoissonSampler} should be
> > used instead.
>
> This is a type in the Javadoc (should have been
> "LargeMeanPoissonSampler", fixed now).
> In my environment, it only triggered a warning.
> Does the policy consider this as a blocker?

I don't think Javadoc errors are blockers per se, however a failing
build seems to me like a blocker unless there are extenutating
circumstances.
For example a very rarely used JVM/OS combination.

Whilst it may be tedious to fix this, if we don't, there are likely to
be ongoing complaints about the issue that will have to be dealt with,
possibly causing more work overall.

> Gilles
>
> > [ERROR]                            ^
> > [ERROR]
> > [ERROR] Command line was:
> >
> > /Library/Java/JavaVirtualMachines/jdk-9.0.4.jdk/Contents/Home/bin/javadoc
> > @options @packages
> > [ERROR]
> > [ERROR] Refer to the generated Javadoc files in
> >
> > '/Users/tompkicr/Desktop/commons-rng/source/commons-rng-1.2-src/commons-rng-sampling/target/site/apidocs'
> > dir.
> >
> >> On Dec 3, 2018, at 8:19 PM, Gilles <gilles@xxxxxxxxxxxxxxxxxxxxx>
> >> wrote:
> >>
> >> Hello.
> >>
> >> I would like to release Apache Commons RNG v1.2.
> >>
> >> Apache Commons RNG 1.2 RC1 is available for review:
> >>    https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1 (svn
> >> revision 31333)
> >>
> >> The Git tag for this RC is "RNG_1_2_RC1":
> >>
> >> https://git-wip-us.apache.org/repos/asf?p=commons-rng.git;a=tag;h=refs/tags/RNG_1_2_RC1
> >>
> >> Maven artifacts:
> >>
> >> https://repository.apache.org/content/repositories/orgapachecommons-1397/org/apache/commons/
> >>
> >> Maven artifacts' SHA-512 hashes in Nexus:
> >>
> >> commons-rng-1.2-bin-tar.gz=beba8312f8702563b7d2a8b3919e812b60e509342fb102274b1fef8107c67d8419b74a82b7c6fd6fdfd9ed03cd590751a80ca27614cca2a909ba057e3c513ef7
> >>
> >> commons-rng-1.2-bin-tar.gz.asc=500c67f4c3c1fdc6583fab068f20664e7235e5f983dcc90c1c9d70290bf5eb3e4a76d7fb3eba56f4a3e8e957bf0c490db237698419c95e2dbca8716f393def4c
> >>
> >> commons-rng-1.2-src-tar.gz=a9325efec521ff3f3489fa67568bc91b5a89014c888d81d14a39e669cf678648ba60722e3f3320ad643d9e84ef3193f272bfd78b4495044b6a763a6442590a3f
> >>
> >> commons-rng-1.2-bin-zip=55342112a7e505882ad5739233508d2957c396f71bf22a45226844bf5ccdfb4947066a0fb111f1a51287ef359bdd1e84f9c7fdde7c3a02092b4cf45aa9eb3d99
> >>
> >> commons-rng-1.2-src-zip=f2d7dbabb1479afd15adae00e9007480638d7c8b5a2900d1d43ec7497efd8f2a0a66bc84032c642de6b3ecf0829a01d3c6748e583b43476f4f36466667fe2292
> >>
> >> commons-rng-1.2-src-zip.asc=e931a42202b3ba274ca07251d8114066c88085014823c421b0cba15c300596aad1d7a7c7f42f85fe0e62cfa3ab4dd4a7afd32ab18149d42e5e775c9c2bf0e187
> >>
> >> commons-rng-1.2-pom.asc=4c9ebbb00fbc1b7f7a679c1f165fc6561ad69fd5e7ec2b268d89c26053643a9574ac69876d47cc8e1a27f595010a6466c4f679518ee7dec5b9c250a5a4720089
> >>
> >> commons-rng-1.2-bin-zip.asc=30e72114890ad6551fb2dc21251d787cf7410d22c92960375d2bfc8586279d1981261af74ce9477313bd1dac4ee632d94100c0db6340a216e385c947b491f432
> >>
> >> commons-rng-1.2-src-tar.gz.asc=e1a04875744dc3cd5b04bfbe5c6fa52e553ecc645c5923db53259202daf28f5fd8570c84a9fcb0ae10669a0924101d4d737ca23fb9cbcd4da7f708ce67c6b5f8
> >>
> >> Details of changes:
> >>
> >> https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/RELEASE-NOTES.txt
> >>
> >> https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/site/changes-report.html
> >>
> >> Site:
> >>    http://commons.apache.org/proper/commons-rng/
> >>
> >> KEYS:
> >>   id=B39617E095CD748DFE505816703413011E22D5B8
> >>   https://www.apache.org/dist/commons/KEYS
> >>
> >> Please review the release candidate and vote.
> >> This vote will close no sooner that 72 hours from now.
> >>
> >>  [ ] +1 Release these artifacts
> >>  [ ] +0 OK, but...
> >>  [ ] -0 OK, but really should fix...
> >>  [ ] -1 I oppose this release because...
> >>
> >> Thanks,
> >> Gilles
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxxxx
> For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxxxx
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxxxx