osdir.com

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] commons-imaging pull request #38: Cleaned up PNG component.


GitHub user SukantPal opened a pull request:

    https://github.com/apache/commons-imaging/pull/38

    Cleaned up PNG component.

    Following changes were made (overview): PngWriter.ImageHeader removed (replaced  by making PngChunkIhdr mutable); divided PngWriter.writeImage (by creating pixel data writing method).
    
    Introduced ChunkLoader. Instead of embedding the chunk loading process in the PngImageParser, I have separated it into ChunkLoader.
    
    I hope these changes will make the code more modular and readable.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/SukantPal/commons-imaging master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-imaging/pull/38.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #38
    
----
commit 9c5b06220b66b2c26baf5ebc8e84f56fe07b4b34
Author: shukant <shukant@...>
Date:   2018-11-30T03:56:55Z

    Cleaned up PNG component.
    
    
    Following changes were made (overview): PngWriter.ImageHeader removed (replaced  by making PngChunkIhdr mutable); divided PngWriter.writeImage (by creating pixel data writing method).
    
    Introduced ChunkLoader. Instead of embedding the chunk loading process in the PngImageParser, I have separated it into ChunkLoader.

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxxxx