[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [All] CP definitions

On Wed, 19 Sep 2018 09:36:25 -0400, Rob Tompkins wrote:
On Sep 19, 2018, at 9:28 AM, Gilles <gilles@xxxxxxxxxxxxxxxxxxxxx> wrote:

On Wed, 19 Sep 2018 06:45:13 -0600, Gary Gregory wrote:
The difference is to account for artifact ids that contain a version like commons-lang3. The component id is then just commons-lang. You must not have versions in names for certain names like in the download page. This
change will probably break builds like pool, dbcp, lang, and so on.

Hmm, this completes the confusion!

If "artifactId" is e.g. commons-lang3 then I don't understand how
the reverted line works because (AFAICT) the SVN URL is

The [Math] POM contains these lines:
<!-- Do not change: "math" is the name of the component even if the
        name of the base package evolves with major release numbers
        (see "commons.osgi.symbolicName", below). -->
Correct or not?

Half of the components are correct, half aren’t.

What’s the consensus here? My thought was that componentId=math is
actually correct based on the documentation, and we need and
“artifactIdSuffix” or something analogous.

We need to reduce the number of variations on a name.

I propose something like:


Then, all the various names can be constructed, and
hopefully most of the currently duplicated functionality
can be removed, and the "right things" be done in CP.



It also uses a fix string:

whereas a variable (as in the commit below) would seem more portable.

Why isn't "<commons.scmPubUrl>" defined in CP only (using the appropriate
variable overridden in each component)?

Why having
that doesn't look at all like a "path"?
We could define a quite more explicit "<commons.component.name>"
that could serve for composing a path, as well as for any
other purpose where the component is meant, independently
of artefact identifier syntax or major version.



On Wed, Sep 19, 2018, 04:07 Gilles <gilles@xxxxxxxxxxxxxxxxxxxxx> wrote:


Are we sure that the fix/revert below to work as intended for
*all* components?

Common usage should be enforced (e.g. to allow anyone to help
releasing any component), and ancient inconsistencies fixed.

With a concrete example of a component that has had major
version changes (and top-level package change accordingly),
what is
and what is


On Wed, 19 Sep 2018 08:06:17 -0000, britter@xxxxxxxxxx wrote:
> Author: britter
> Date: Wed Sep 19 08:06:17 2018
> New Revision: 1841296
> URL: http://svn.apache.org/viewvc?rev=1841296&view=rev
> Log:
> COMMONSSITE-124: Revert change in commons.scmPubUrl in Parent 47
> Modified:
>     commons/proper/commons-parent/trunk/pom.xml
>     commons/proper/commons-parent/trunk/src/changes/changes.xml
> Modified: commons/proper/commons-parent/trunk/pom.xml
> URL:


> --- commons/proper/commons-parent/trunk/pom.xml (original)
> +++ commons/proper/commons-parent/trunk/pom.xml Wed Sep 19 08:06:17
> 2018
> @@ -1940,7 +1940,7 @@
>      <!-- value modules can override it -->
> <commons.site.path>${commons.componentid}</commons.site.path>
> -
> <commons.scmPubUrl>

> +
> <commons.scmPubUrl>


>      <commons.scmPubServer>commons.site</commons.scmPubServer>
> Modified: commons/proper/commons-parent/trunk/src/changes/changes.xml
> URL:


> --- commons/proper/commons-parent/trunk/src/changes/changes.xml
> (original)
> +++ commons/proper/commons-parent/trunk/src/changes/changes.xml Wed
> Sep 19 08:06:17 2018
> @@ -61,6 +61,7 @@ The <action> type attribute can be add,u
>      <body>
> <release version="48" date="YYYY-MM-DD" description="TBD">
> +            <action issue="COMMONSSITE-124" type="fix"
> dev="britter">Revert change in commons.scmPubUrl in Parent
> 47</action>
>              <action type="update">Update parent from
> org.apache:apache 19 to 20.</action>
> <action type="update">maven-compiler-plugin 3.7.0 ->
> 3.8.0</action>
> <action type="fix">re-enabled japicmp and introduced
> japicmp.skip property that

To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxxxx