osdir.com


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [parent] change in commons.scmPubUrl in Parent 47


I have created COMMONSSITE-124 [1] in order to fix this. Will implement a
fix later today.

Benedikt

[1] https://issues.apache.org/jira/browse/COMMONSSITE-124

Am Fr., 31. Aug. 2018 um 13:24 Uhr schrieb Benedikt Ritter <
britter@xxxxxxxxxx>:

>
>
> Am Fr., 31. Aug. 2018 um 11:38 Uhr schrieb sebb <sebbaz@xxxxxxxxx>:
>
>> On 31 August 2018 at 10:16, Benedikt Ritter <britter@xxxxxxxxxx> wrote:
>> > Hello,
>> >
>> > I upgraded commons-csv from parent v43 to parent v47. Now the site build
>> > doesn't work anymore (see below). I think we should roll back said
>> chance,
>> > since it broke multiple working component builds.
>>
>> Which change are you talking about?
>>
>
> The one from the thread title...
>
>
>>
>> Note that if a CP version causes problems, just don't use it.
>> Either revert to an earlier version or release a new one that fixes
>> the issue and then use that.
>>
>> > Benedikt
>> >
>> > commons-csv build log:
>> >
>> > ~/w/a/c/commons-csv git:(master) 1M > mvn site
>> > [INFO] Scanning for projects...
>> > [INFO]
>> > [INFO] -------------------< org.apache.commons:commons-csv
>> >>-------------------
>> > [INFO] Building Apache Commons CSV 1.6-SNAPSHOT
>> > [INFO] --------------------------------[ jar
>> > ]---------------------------------
>> > [INFO]
>> > [INFO] --- maven-antrun-plugin:1.8:run (prepare-checkout) @ commons-csv
>> ---
>> > [WARNING] Parameter tasks is deprecated, use target instead
>> > [INFO] Executing tasks
>> >
>> > main:
>> >      [exec] svn: E170000: URL '
>> >
>> https://svn.apache.org/repos/infra/websites/production/commons/content/proper/csv
>> '
>> > doesn't exist
>> >      [exec] Result: 1
>> >      [exec] Skipped '/Users/bene/commons-sites/csv/javadocs'
>> >      [exec] svn: E155007: None of the targets are working copies
>> >      [exec] Result: 1
>> > [INFO]
>> > ------------------------------------------------------------------------
>> > [INFO] BUILD FAILURE
>> > [INFO]
>> > ------------------------------------------------------------------------
>> > [INFO] Total time: 3.199 s
>> > [INFO] Finished at: 2018-08-31T11:13:39+02:00
>> > [INFO]
>> > ------------------------------------------------------------------------
>> > [ERROR] Failed to execute goal
>> > org.apache.maven.plugins:maven-antrun-plugin:1.8:run (prepare-checkout)
>> on
>> > project commons-csv: An Ant BuildException has occured:
>> > /Users/bene/commons-sites/csv does not exist.
>> > [ERROR] around Ant part ...<pathconvert property="dirs" pathsep=" ">...
>> @
>> > 10:44 in
>> >
>> /Users/bene/workspace/apache/commons/commons-csv/target/antrun/build-main.xml
>> > [ERROR] -> [Help 1]
>> > [ERROR]
>> > [ERROR] To see the full stack trace of the errors, re-run Maven with
>> the -e
>> > switch.
>> > [ERROR] Re-run Maven using the -X switch to enable full debug logging.
>> > [ERROR]
>> > [ERROR] For more information about the errors and possible solutions,
>> > please read the following articles:
>> > [ERROR] [Help 1]
>> > http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
>> >
>> >
>> >
>> > Am Mi., 22. Aug. 2018 um 21:22 Uhr schrieb Benedikt Ritter <
>> > britter@xxxxxxxxxx>:
>> >
>> >>
>> >>
>> >> Am Mi., 22. Aug. 2018 um 14:33 Uhr schrieb Gilles <
>> >> gilles@xxxxxxxxxxxxxxxxxxxxx>:
>> >>
>> >>> On Wed, 22 Aug 2018 08:11:03 -0400, Rob Tompkins wrote:
>> >>> >> On Aug 22, 2018, at 1:47 AM, Benedikt Ritter <britter@xxxxxxxxxx>
>> >>> >> wrote:
>> >>> >>
>> >>> >> Hi,
>> >>> >>
>> >>> >> I don't understand this discussion. Changes in Commons Parent have
>> >>> >> broken
>> >>> >> the commons-compress build. So we should either roll this changes
>> >>> >> back or
>> >>> >> those who need the changes in commons parent should fix the commons
>> >>> >> compress build.
>> >>> >
>> >>> > I think the problem at hand here is that we, across our projects,
>> are
>> >>> > inconsistent with our usage of componentId, so naturally any changes
>> >>> > to the way we consume it in the parent are breaking changes. For
>> >>> > example:
>> >>> >
>> >>> > https://github.com/apache/commons-lang/blob/master/pom.xml#L573
>> >>> > <https://github.com/apache/commons-lang/blob/master/pom.xml#L573>
>> >>>
>> >>> This one is wrong, according to a convention explicitly mentioned
>> >>> in some POM files, e.g.:
>> >>> ---CUT---
>> >>>      <!-- Do not change: "rng" is the name of the component even if
>> the
>> >>>           name of the base package evolves with major release numbers
>> >>>           (see "commons.osgi.symbolicName", below). -->
>> >>>      <commons.componentid>rng</commons.componentid>
>> >>> ---CUT---
>> >>>
>> >>
>> >> I've raised LANG-1414 [1] to fix this.
>> >>
>> >> Benedikt
>> >>
>> >> [1] https://issues.apache.org/jira/browse/LANG-1414
>> >>
>> >>
>> >>>
>> >>> Gilles
>> >>>
>> >>> > versus
>> >>> >
>> >>> >
>> https://github.com/apache/commons-collections/blob/master/pom.xml#L487
>> >>> >
>> >>> > <
>> https://github.com/apache/commons-collections/blob/master/pom.xml#L487
>> >>> >
>> >>> >
>> >>> > -Rob
>> >>> >
>> >>> >
>> >>> >>
>> >>> >> Regards,
>> >>> >> Benedikt
>> >>> >>
>> >>> >> Am Do., 16. Aug. 2018 um 19:08 Uhr schrieb Gary Gregory <
>> >>> >> garydgregory@xxxxxxxxx>:
>> >>> >>
>> >>> >>> On Thu, Aug 16, 2018 at 10:27 AM Stefan Bodewig
>> >>> >>> <bodewig@xxxxxxxxxx>
>> >>> >>> wrote:
>> >>> >>>
>> >>> >>>> On 2018-08-16, Gary Gregory wrote:
>> >>> >>>>
>> >>> >>>>> I've use the release plugin a bunch without trouble. You might
>> >>> >>>>> want to
>> >>> >>>> see
>> >>> >>>>> how other POMs are configured, for example [dbcp].
>> >>> >>>>
>> >>> >>>> The same way as Compress (no commons- prefix), I've got no idea
>> >>> >>>> why
>> >>> >>>> running site-deploy should work for it.
>> >>> >>>>
>> >>> >>>> You use the release plugin if you only want to publish the site
>> >>> >>>> and not
>> >>> >>>> cut a release?
>> >>> >>>>
>> >>> >>>
>> >>> >>> I use the plugin build the dist folder (which includes a site) and
>> >>> >>> generate
>> >>> >>> the vote email text. For the real site, after the vote, I use the
>> >>> >>> stock
>> >>> >>> site-deploy goal.
>> >>> >>>
>> >>> >>>
>> >>> >>>>
>> >>> >>>>> You have to keep in mind that components like Collections, Lang,
>> >>> >>>>> Pool,
>> >>> >>>> and
>> >>> >>>>> DBCP, the folder name is different from the artifact id because
>> >>> >>>>> the
>> >>> >>>>> artifact id contains a major version number, for example
>> >>> >>>>> commons-lang
>> >>> >>> is
>> >>> >>>>> the folder but commons-lang3 is the AID.
>> >>> >>>>
>> >>> >>>> The parent POM says about componentId:
>> >>> >>>>
>> >>> >>>>    <!-- The Commons Component id is substring of the package name
>> >>> >>>> from
>> >>> >>>> o.a.commons.(.*)., for example:
>> >>> >>>>         - Use dbcp2 instead of dbcp.
>> >>> >>>>         - Use collections4 instead of collections.
>> >>> >>>>         - Use lang3 instead of lang.
>> >>> >>>>
>> >>> >>>> is this no longer true and it should be commons-lang instead of
>> >>> >>>> lang by
>> >>> >>>> now?
>> >>> >>>>
>> >>> >>>
>> >>> >>> The comments are misleading:
>> >>> >>>
>> >>> >>>    <!-- The Commons Component id is used on the distribution
>> >>> >>> server, for
>> >>> >>> example:
>> >>> >>>         - Use dbcp instead of dbcp2.
>> >>> >>>         - Use collections instead of collections4.
>> >>> >>>         - Use lang instead of lang3.
>> >>> >>>         - Use pool instead of pool2.
>> >>> >>>         - and so on...
>> >>> >>>    -->
>> >>> >>>
>> <commons.componentid>${project.artifactId}</commons.componentid>
>> >>> >>>    <!-- The Commons Component id is substring of the package name
>> >>> >>> from
>> >>> >>> o.a.commons.(.*)., for example:
>> >>> >>>         - Use dbcp2 instead of dbcp.
>> >>> >>>         - Use collections4 instead of collections.
>> >>> >>>         - Use lang3 instead of lang.
>> >>> >>>         - Use pool2 instead of pool.
>> >>> >>>         - and so on...
>> >>> >>>    -->
>> >>> >>>    <commons.packageId>${project.artifactId}</commons.packageId>
>> >>> >>>
>> >>> >>> For the seconds comment it should read
>> >>> >>>    <!-- The package id is substring of the package name from
>> >>> >>> o.a.commons.(.*)., for example:
>> >>> >>>
>> >>> >>> See the Commons Pool POM as an example.
>> >>> >>>
>> >>> >>> Gary
>> >>> >>>
>> >>> >>>
>> >>> >>>>
>> >>> >>>> Stefan
>> >>> >>>>
>> >>> >>>>
>> >>> >>>>
>> ---------------------------------------------------------------------
>> >>> >>>> To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxxxx
>> >>> >>>> For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxxxx
>> >>> >>>>
>> >>> >>>>
>> >>> >>>
>> >>>
>> >>>
>> >>> ---------------------------------------------------------------------
>> >>> To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxxxx
>> >>> For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxxxx
>> >>>
>> >>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxxxx
>> For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxxxx
>>
>>