osdir.com


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [ALL] Make checkstyle:check part of default maven goal?



> On Aug 27, 2018, at 2:33 PM, Pascal Schumacher <pascalschumacher@xxxxxxx> wrote:
> 
> At least RAT and clirr/japicmp should be part of default goal.
> 
> I'm personally prefer checkstyle and findbugs/spotbugs (although I prefer error-prone nowadays) to be part of the default goal.
> 
> On Java 8+ it is also helpful to make javadoc part of the default goal.
> 
> I think it is very convenient to be able to execute everything with "mvn" before committing and have the build fail if there are any violations. It is also helpful for pull request, because travis can run the default goal too.
> 
> By the way: lang and text already have all these as default goal and io is just missing findbugs.
> 
> Cheers,
> Pascal

I’m a +1 to this idea. 

-Rob

> 
>> Am 20.08.2018 um 21:06 schrieb Gary Gregory:
>> The RAT check should be turned on by default IMO.
>> 
>> Gary
>> 
>>> On Mon, Aug 20, 2018 at 12:45 AM Benedikt Ritter <britter@xxxxxxxxxx> wrote:
>>> 
>>> Hi,
>>> 
>>> one thing I always have to do when preparing a release is to fix all the
>>> checkstyle and findbugs errors. This step could be eliminated if we added
>>> checkstyle:check and findbugs:check to the maven default goal. This way it
>>> would be executed on CI builds and we would see failing checkstyle/findbugs
>>> right away.
>>> 
>>> WDYT?
>>> Benedikt
>>> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxxxx
> For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxxxx
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxxxx