osdir.com


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] commons-imaging pull request #35: IMAGING-154 Removed Debug class


Github user kinow commented on a diff in the pull request:

    https://github.com/apache/commons-imaging/pull/35#discussion_r210549560
  
    --- Diff: src/main/java/org/apache/commons/imaging/formats/bmp/BmpImageParser.java ---
    @@ -327,7 +331,7 @@ private BmpImageContents readImageContents(final InputStream is,
             switch (bhi.compression) {
             case BI_RGB:
                 if (verbose) {
    --- End diff --
    
    And on
    
    >(wonder if we should use FINEST for debug, and FINE for the verbose messages...)
    
    If you have the chance to run the tests, you will notice the huge amount of verbose messages being printed now. I believe some users could be inundated with log lines (as the INFO is enabled by default? and verbose was disabled by default)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxxxx