osdir.com


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] commons-rng pull request #9: Improvement rng 50


GitHub user aherbert opened a pull request:

    https://github.com/apache/commons-rng/pull/9

    Improvement rng 50

    This adds the PoissonSamplerCache that can be used for faster construction of PoissonSamplers.
    
    I've added tests for the edge conditions in the constructors and to ensure the sequence of Poisson samples is the same whether the cache is used to create the sampler or just the PoissonSampler constructor.
    
    I have also added functionality to create a new cache from an existing one allowing the cached values to be recycled into a new range.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aherbert/commons-rng improvement-RNG-50

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-rng/pull/9.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #9
    
----
commit ad5641428ed3dcf1be41b95266f96d31746f3741
Author: Alex Herbert <a.herbert@...>
Date:   2018-08-06T22:33:29Z

    RNG-50: Changed PIVOT to package scope for the PoissonSamplerCache

commit 5f05ae70accd2a38b76eadd8e63dcdc71ed45975
Author: Alex Herbert <a.herbert@...>
Date:   2018-08-06T22:36:11Z

    RNG-50: Added PoissonSamplerCache
    
    The cache minimises construction cost of the PoissonSampler for
    single-use Poisson samples. The returned sampler should exactly match
    the sampler created with the PoissonSampler constructor when generating
    samples.

commit c715924b2a9f7e882f2c04272794b546bcb2d32c
Author: Alex Herbert <a.herbert@...>
Date:   2018-08-06T23:25:42Z

    RNG-50: Updated comments on the test

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxxxx