osdir.com


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] commons-text pull request #87: Fix [TEXT-130] and [TEXT-131]


GitHub user jmkeil opened a pull request:

    https://github.com/apache/commons-text/pull/87

    Fix [TEXT-130] and [TEXT-131]

    Fixes [TEXT-130](https://issues.apache.org/jira/browse/TEXT-130) and [TEXT-131](https://issues.apache.org/jira/browse/TEXT-131).
    
    Changes made:
    * add testcase for both issues
    * update existing tests to comply with definition of Jaro-Winkler Similarity
    * update `JaroWinklerDistance#matches` and `JaroWinklerDistance#apply` as described in the issues
    * update documentation of `JaroWinklerDistance#matches`

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jmkeil/commons-text master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-text/pull/87.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #87
    
----
commit 70150fba9a0e26d944b0f649265a567309ba3af4
Author: Jan Martin Keil <jan-martin.keil@...>
Date:   2018-08-02T20:51:18Z

    Testcase for [TEXT-130] JaroWinklerDistance: Wrong results due to precision of transpositions

commit 4d064decbf7828918ca59b70d7fca19b7da955ec
Author: Jan Martin Keil <jan-martin.keil@...>
Date:   2018-08-02T20:55:00Z

    Fix [TEXT-130] JaroWinklerDistance: Wrong results due to precision of transpositions

commit 4546f45c7ed610b94336b7a60592ac77382f6fdb
Author: Jan Martin Keil <jan-martin.keil@...>
Date:   2018-08-02T21:04:32Z

    Testcases for [TEXT-131] JaroWinklerDistance: Calculation deviates from definition

commit 5d148549bc6ea8501016856547e27aed58b116c3
Author: Jan Martin Keil <jan-martin.keil@...>
Date:   2018-08-02T21:20:21Z

    Fix [TEXT-131] JaroWinklerDistance: Calculation deviates from definition

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxxxx