osdir.com


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] commons-rng pull request #8: Improvement rng 50


GitHub user aherbert opened a pull request:

    https://github.com/apache/commons-rng/pull/8

    Improvement rng 50

    The algorithms for small mean and large mean have been separated into
    dedicated classes. Caching of constants used in the algorithm has been
    used to increase speed.
    
    Note: I have run `mvn clean verify` within the `commons-rng-sampling` module but the randomness of the `ContinuousSamplerParametricTest` causes it to fail on different distributions. I have seen failures on:
    
    - Box-Muller Gaussian deviate
    - org.apache.commons.math3.distribution.LevyDistribution (inverse method)
    
    These are unrelated to the PoissonSampler.
    
    I ran `mvn clean verify -DskipTests=true` and that had no errors. 
    
    No checkstyle errors in the project files modified in this PR.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aherbert/commons-rng improvement-RNG-50

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-rng/pull/8.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #8
    
----
commit 7b4a41428c2bed270261b4fedd3a562adaee04b5
Author: aherbert <a.herbert@...>
Date:   2018-08-01T11:09:28Z

    RNG-50: PoissonSampler speed improvements
    
    The algorithms for small mean and large mean have been separated into
    dedicated classes. Caching of constants used in the algorithm has been
    used to increase speed.

commit 9704699b403f23939529e14b0560cabf00530d98
Author: aherbert <a.herbert@...>
Date:   2018-08-01T11:40:04Z

    RNG-50: PoissonSampler speed improvements
    
    Fixed checkstyle errors

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxxxx