osdir.com


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [GitHub] commons-io pull request #62: IO-578: Support java.nio.Path and non-default f...


Hello,

I've created the issue IO-768<https://issues.apache.org/jira/browse/IO-578> "Support java.nio.Path and non-default filesystems for ReversedLinesFileReader" and a corresponding pull request apache/commons-io#62<https://github.com/apache/commons-io/pull/62> to address a limitation I encountered trying to use ReversedLinesFileReader with a non-default file system, Jimfs<https://github.com/google/jimfs>, i.e. on Java 7+. I hope you'll agree the contribution is a good fit for a future release of Commons IO. I'd appreciate any code review or other feedback.



Thanks,

Mark



-----Original Message-----
From: mches <git@xxxxxxxxxxxxxx>
Sent: Thursday, May 31, 2018 6:17 PM
To: dev@xxxxxxxxxxxxxxxxxx
Subject: [GitHub] commons-io pull request #62: IO-578: Support java.nio.Path and non-default f...



GitHub user mches opened a pull request:



    https://github.com/apache/commons-io/pull/62



    IO-578: Support java.nio.Path and non-default filesystems for ReversedLinesFileReader







You can merge this pull request into a Git repository by running:



    $ git pull https://github.com/NSIT/commons-io IO-578-ReversedLinesFileReader



Alternatively you can review and apply these changes as the patch at:



    https://github.com/apache/commons-io/pull/62.patch



To close this pull request, make a commit to your master/trunk branch

with (at least) the following in the commit message:



    This closes #62



----

commit 8108b20bfe23fcf161a6284ef398932f19d0ed82

Author: Mark Chesney <mark.chesney@...<mailto:mark.chesney@...>>

Date:   2018-06-01T01:09:18Z



    IO-578: Support java.nio.Path and non-default filesystems for ReversedLinesFileReader



----





---



---------------------------------------------------------------------

To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxxxx<mailto:dev-unsubscribe@xxxxxxxxxxxxxxxxxx>

For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxxxx<mailto:dev-help@xxxxxxxxxxxxxxxxxx>