OSDir


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [VOTE] Release Apache Commons Pool 2.6.0 based on RC1


+1, 

builds/tests on java 7, 8, 10.0.1

site works on 7 and 8.

Signatures, Rat ok.

Agree with Oliver’s nits.

-Rob


> On Jul 4, 2018, at 3:51 PM, Oliver Heger <oliver.heger@xxxxxxxxxxxxxxx> wrote:
> 
> Build works fine with Java 8 on Windows 10. Artifacts and site look good.
> 
> +1
> 
> One minor point I noticed is that the release notes say that "Version 2
> requires JDK level 1.6 or above", but the minimum JDK for 2.6 is 1.7.
> 
> There are also a few checkstyle errors that could be fixed with not too
> much effort.
> 
> Oliver
> 
> Am 04.07.2018 um 00:27 schrieb Gary Gregory:
>> We have fixed quite a few bugs and added some significant enhancements
>> since Apache Commons Pool 2.5.0 was released, so I would like to release
>> Apache Commons Pool 2.6.0.
>> 
>> Apache Commons Pool 2.6.0 RC1 is available for review here:
>>    https://dist.apache.org/repos/dist/dev/commons/pool/2.6.0-RC1 (svn
>> revision 27911)
>> 
>> The Git tag commons-pool-2.6.0-RC1 commit for this RC is
>> 281258e546f761a00e3379d7db4d6744e721d3c3 which you can browse here:
>> 
>> https://git-wip-us.apache.org/repos/asf?p=commons-pool.git;a=tag;h=refs/tags/commons-pool-2.6.0-RC1
>> 
>> Maven artifacts are here:
>> 
>> https://repository.apache.org/content/repositories/orgapachecommons-1342/org/apache/commons/commons-pool2/2.6.0/
>> 
>> These are the Maven artifacts and their hashes in Nexus:
>> 
>> #Release SHA-1s
>> #Tue Jul 03 16:18:24 MDT 2018
>> commons-pool2-2.6.0-src-tar.gz.asc=5a28d06adbac3b3775377ae8b62bd1938ae9c3dd
>> commons-pool2-2.6.0-bin-tar.gz=ce825b0e6ed22538d4c7b53d4fedeada3430a711
>> commons-pool2-2.6.0-pom.asc=7c00018a883cc14e09bff506985636280900f881
>> commons-pool2-2.6.0-sources-jar.asc=3f7319a3259349b609d229c5e38e67b0fd2ec31b
>> commons-pool2-2.6.0-bin-zip.asc=4817da837cce78457f3bece200179576d1ae14f7
>> commons-pool2-2.6.0-jar.asc=7263fdf0061506d25f59b22ae86c2fc8ad6a308b
>> commons-pool2-2.6.0-tests-jar.asc=ce1a3ac57b9257d3ea6491a807d3e59f1d3ad38f
>> commons-pool2-2.6.0-javadoc-jar.asc=c126e1ffef27bda6116ca42041b4511bd562edbf
>> commons-pool2-2.6.0-tests-test-jar=f29918fe848dd6393a77f944d7d8369703a90726
>> commons-pool2-2.6.0-test-sources-jar.asc=b59fe31b13736e3437608cabb3643a53688b211e
>> commons-pool2-2.6.0-src-zip=f5a584517eb4a2c048ae51ea3b2248ce4e59f4fb
>> commons-pool2-2.6.0-bin-tar.gz.asc=b34b7a0a6db6e52292be0cd00d34fd20d2a7977c
>> commons-pool2-2.6.0-src-zip.asc=b81401c71cb7213476f96f993ac35ee07a3cd80f
>> commons-pool2-2.6.0-test-sources-java-source=7b959b3c98ddfcdc0ee296d4e3c2af0ffdbbe765
>> commons-pool2-2.6.0-javadoc-javadoc=fd4b11c3fbf3bc883ce7df8de04962e212cc4277
>> commons-pool2-2.6.0-src-tar.gz=e1944a581006117fa93bf3b2b9e2e3724d2383a6
>> commons-pool2-2.6.0-bin-zip=954e155de24897caf192bf004111fd9d4d50c0df
>> commons-pool2-2.6.0-sources-java-source=6b5036e509a52fe820c9c5a42dbf341f948e729f
>> 
>> #Release SHA-256s
>> #Tue Jul 03 16:18:24 MDT 2018
>> commons-pool2-2.6.0-src-tar.gz.asc=e28a47a44c58c25bc2bdbeee396de15e6d59ef1dc10d3b29472a6b5e31586a95
>> commons-pool2-2.6.0-bin-tar.gz=961606add45d4212951482327d6b541214af1f95ea21b0528628eb031a4af522
>> commons-pool2-2.6.0-pom.asc=755236bb99192f6c4280d781cf7b5c76c8b4215359e42649010dc0a431705b78
>> commons-pool2-2.6.0-sources-jar.asc=4f5c54e1b05ad74eee66adde3efc984403cca577bb84d5e13469766185c3b846
>> commons-pool2-2.6.0-bin-zip.asc=01d17755874efaf30bb6990682feea52a05ab7d668590385976d3ef8b6d3b3cf
>> commons-pool2-2.6.0-jar.asc=867ed63ce33afab8543cc7b2e5eaa9b7112b6593eff1b3d13646ba0fc23aca10
>> commons-pool2-2.6.0-tests-jar.asc=1aa0e7cfdd7709c477183a756ff00cc60d098b98eee63889e645a8b4ac974633
>> commons-pool2-2.6.0-javadoc-jar.asc=95dd464a76b92be2a6e485c54cdc76d837ef4a09cc5e4b2c850bd9cdbcaf84b4
>> commons-pool2-2.6.0-tests-test-jar=cefd3d7dde27c17a576b544055f71a346dce83b0276c9664a7aa180793a30468
>> commons-pool2-2.6.0-test-sources-jar.asc=d3a504f2b76eefbb447fc58e5751b93892d5408db15ddbc1b559c1bb8165a6de
>> commons-pool2-2.6.0-src-zip=8af7c55c3d80a9e8613f2af6a277067fa9d54d47acbc9a79c0c2e2f3f368a380
>> commons-pool2-2.6.0-bin-tar.gz.asc=769e71cf3ec1152a04af14ec911494ee61ab33ba4e0cadb2e46b856005adcc82
>> commons-pool2-2.6.0-src-zip.asc=b49da866c6f8ca2aa8f0389b97e0c21c563ea3e4367cdde3f0cc3e82130f2bf7
>> commons-pool2-2.6.0-test-sources-java-source=44120179f216f5ca6e2633e29e03702f79158611e5305b589ab64ca83e8e4000
>> commons-pool2-2.6.0-javadoc-javadoc=d40f49e0e5a86c482fca2d5fb7e4c63b6848ee7fe4e60fdb2141a3efa45c599b
>> commons-pool2-2.6.0-src-tar.gz=006c9d76a3e8aeec908557ca06b9f33661b88e04ad075e4bb63cfd5f1d650c8f
>> commons-pool2-2.6.0-bin-zip=42ed6eebeda1435ce7f82e952341aba7569b1213c4e0bd03108a50e602e1709d
>> commons-pool2-2.6.0-sources-java-source=d729b9d229561ade56cec1ba412835ce86bcde10881848e2101810754bc4bdc0
>> 
>> (no need for .asc hashes!)
>> 
>> I have tested this with 'mvn clean install site' using:
>> 
>> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
>> 2018-06-17T12:33:14-06:00)
>> Maven home: C:\Java\apache-maven-3.5.4\bin\..
>> Java version: 1.8.0_172, vendor: Oracle Corporation, runtime: C:\Program
>> Files\Java\jdk1.8.0_172\jre
>> Default locale: en_US, platform encoding: Cp1252
>> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>> 
>> Details of changes since 2.5.0 are in the release notes:
>> 
>> https://dist.apache.org/repos/dist/dev/commons/pool/2.6.0-RC1/RELEASE-NOTES.txt
>> 
>> https://dist.apache.org/repos/dist/dev/commons/pool/2.6.0-RC1/site/changes-report.html
>> 
>> Site:
>>    https://dist.apache.org/repos/dist/dev/commons/pool/2.6.0-RC1/site
>>    (note some *relative* links are broken and the 2.6.0 directories are
>> not yet created - these will be OK once the site is deployed.)
>> 
>> CLIRR Report (compared to 2.5.0):
>> 
>> https://dist.apache.org/repos/dist/dev/commons/pool/2.6.0-RC1/site/clirr-report.html
>>    Note the known and expected warning 'Value of field
>> DEFAULT_EVICTION_POLICY_CLASS_NAME is no longer a compile-time constant.'
>> 
>> RAT Report:
>> 
>> https://dist.apache.org/repos/dist/dev/commons/pool/2.6.0-RC1/site/rat-report.html
>> 
>> KEYS:
>>  https://www.apache.org/dist/commons/KEYS
>> 
>> Please review the release candidate and vote.
>> This vote will close no sooner that 72 hours from now.
>> 
>>  [ ] +1 Release these artifacts
>>  [ ] +0 OK, but...
>>  [ ] -0 OK, but really should fix...
>>  [ ] -1 I oppose this release because...
>> 
>> Thank you,
>> 
>> Gary Gregory,
>> Release Manager (using key 86fdc7e2a11262cb)
>> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxxxx
> For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxxxx
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxxxx