[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] commons-fileupload pull request #16: Use Apache Commons I/O in tests


GitHub user krichter722 opened a pull request:

    https://github.com/apache/commons-fileupload/pull/16

    Use Apache Commons I/O in tests

    Replace File.delete and File.mkdir with Apache Commons I/O's FileUtils
    equivalent which throw IOException instead of returning false which
    reduces the change to miss unexpected failures and removed assertions
    testing the function of Apache Commons I/O which is not our job.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/krichter722/commons-fileupload commons-io

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-fileupload/pull/16.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #16
    
----
commit 41694d54cf4fc2d8db1d3cb2651e52ed72aab166
Author: Karl-Philipp Richter <krichter722@...>
Date:   2018-05-21T18:12:53Z

    Use Apache Commons I/O in tests
    
    Replace File.delete and File.mkdir with Apache Commons I/O's FileUtils
    equivalent which throw IOException instead of returning false which
    reduces the change to miss unexpected failures and removed assertions
    testing the function of Apache Commons I/O which is not our job.

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxxxx