OSDir


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [all] Regarding pom.xml commons.componentId


Other IDs: Java 9 modules and OSGi bundle names.

On Mon, Jun 11, 2018 at 4:28 PM sebb <sebbaz@xxxxxxxxx> wrote:

> On 11 June 2018 at 21:13, Rob Tompkins <chtompki@xxxxxxxxx> wrote:
> >
> >
> >> On Jun 11, 2018, at 3:55 PM, Gary Gregory <garydgregory@xxxxxxxxx>
> wrote:
> >>
> >> The best IMO is “commons.packageId” for "lang3”.
> >
> > Sounds good….will head that direction.
>
> I think the most important aspect is to very carefully document what
> the variable is used for.
>
> >>
> >> Gary
> >>
> >> On Mon, Jun 11, 2018 at 1:41 PM Rob Tompkins <chtompki@xxxxxxxxx>
> wrote:
> >>
> >>>
> >>>
> >>>> On Jun 11, 2018, at 11:58 AM, Gary Gregory <garydgregory@xxxxxxxxx>
> >>> wrote:
> >>>>
> >>>> I think the first statement needs to be checked and code maybe
> changed to
> >>>> adjust for the fact that we have both the artifact id and component
> id to
> >>>> play with.
> >>>
> >>> The issue is that we only have two names for 3 values. Values, for
> lang:
> >>>
> >>> commons-lang3 (artifactId)
> >>> lang3 (needed for osgi, in lang called componentid)
> >>> lang (actual component id needed for urls and such).
> >>>
> >>> IMO, we would want to call lang3 “commons.artifactId.suffix”, or
> >>> “commons.packageId”
> >>>
> >>> Or, if we wanted lang3 to be “commons.componentid” then have “lang” be
> >>> called “commons.componentName”
> >>>
> >>> Thoughts?
> >>> -Rob
> >>>
> >>>>
> >>>> The page generation works now BTW with the SNAPSHOT build, which I
> used
> >>> for
> >>>> Commons Text 1.4 RC1.
> >>>>
> >>>> Gary
> >>>>
> >>>> On Mon, Jun 11, 2018 at 9:39 AM Rob Tompkins <chtompki@xxxxxxxxx>
> wrote:
> >>>>
> >>>>> I’m a tad worried about these two conflicting statements (thoughts?):
> >>>>>
> >>>>>
> >>>>> ------------------
> >>>>> commons-lang, pom.xml: 562-573
> >>>>>    <!--
> >>>>>      This is also  used to generate download_xxx file name.
> >>>>>      To override this when generating the download page:
> >>>>>      mvn commons:download-page -Dcommons.componentid=lang
> >>>>>      The above seems to change the download page name but not any
> other
> >>>>>      properties that depend on the componentid.
> >>>>>      N.B. The componentid is also used by the parent pom as part of
> the
> >>>>> OSGI symbolic name.
> >>>>>   -->
> >>>>>   <commons.componentid>lang3</commons.componentid>
> >>>>>
> >>>>>
> >>>>> ------------------
> >>>>> commons-parent, pom.xml: 1847-1854
> >>>>>   <!-- The Commons Component id is used on the distribution server,
> for
> >>>>> example:
> >>>>>        - Use dbcp instead of dbcp2.
> >>>>>        - Use collections instead of collections4.
> >>>>>        - Use lang instead of lang3.
> >>>>>        - Use pool instead of pool2.
> >>>>>        - and so on...
> >>>>>   -->
> >>>>>   <commons.componentid>${project.artifactId}</commons.componentid>
> >>>>>
> >>>>>
> >>>>>
> >>>>> ---------------------------------------------------------------------
> >>>>> To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxxxx
> >>>>> For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxxxx
> >>>>>
> >>>>>
> >>>
> >>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxxxx
> >>> For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxxxx
> >>>
> >>>
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxxxx
> > For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxxxx
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxxxx
> For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxxxx
>
>