osdir.com

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[collections] breaking changes


Hi All:

Updating Commons Collections' commons-parent from version 43 to 45 causes
the build to fail due to the use of japicmp which reports:

[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-site-plugin:3.7:site (default-site) on
project commons-collections4: Error generating
japicmp-maven-plugin:0.11.0:cmp-report report: Failed to generate report:
Breaking the build because there is at least one incompatibility:
org.apache.commons.collections4.IteratorUtils.peekingIterator(java.util.Iterator):METHOD_RETURN_TYPE_CHANGED,org.apache.commons.collections4.IteratorUtils.pushbackIterator(java.util.Iterator):METHOD_RETURN_TYPE_CHANGED
-> [Help 1]

This is caused by:

- [COLLECTIONS-676] Modify IteratorUtils.pushbackIterator signature to
return PushbackIterator.
- [COLLECTIONS-675] Modify IteratorUtils.peekingIterator signature to
return PeekingIterator.

Which are reasonable changes IMO.

Does anyone object to these changes and adding exceptions to allow japicmp to
not fail the build?

Thank you,
Gary