osdir.com

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [GitHub] rafaelweingartner commented on issue #2761: Add managed storage pool constraints to MigrateWithVolume API method


Sure, it’s no rush for me.

Just let me know when you’re ready for me to merge it or feel free to merge it yourself.

> On Aug 2, 2018, at 5:08 AM, GitBox <git@xxxxxxxxxx> wrote:
> 
> rafaelweingartner commented on issue #2761: Add managed storage pool constraints to MigrateWithVolume API method
> URL: https://github.com/apache/cloudstack/pull/2761#issuecomment-409890686
> 
> 
>   @DaanHoogland that is what I was going to say to Mike. We can squash at the merge "moment".
> 
>   Can we wait more one week or so before merging? I would like to cover this code with unit tests. It is a very complicated and delicate one code, and it does not have unit-tests for it.
> 
> ----------------------------------------------------------------
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on GitHub and use the
> URL above to go to the specific comment.
> 
> For queries about this service, please contact Infrastructure at:
> users@xxxxxxxxxxxxxxxx
> 
> 
> With regards,
> Apache Git Services