osdir.com

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [VOTE] Release apache-calcite-1.18.0 (release candidate 0)


I concur that https://issues.apache.org/jira/browse/CALCITE-2726 <https://issues.apache.org/jira/browse/CALCITE-2726> is a blocker. I’ll send a cancel shortly, and we’ll make an RC1 when 2726 is fixed.

Folks, please continue running whatever tests you run to validate a Calcite release. If there are other such issues, let’s find them all in the first pass.

Julian



> On Dec 5, 2018, at 9:29 AM, Andrew Pilloud <apilloud@xxxxxxxxxx.INVALID> wrote:
> 
> +1 (non-binding)
> 
> - Upgraded Beam, all tests pass against staged artifacts.
> https://github.com/apache/beam/pull/7209/files
> - Tested with Beam moved to Calcite's EnumerableCalc codegen, all tests
> pass against staged artifacts.
> 
> Thanks for getting this release out! This unblocks a huge code reduction in
> Beam SQL.
> 
> On Wed, Dec 5, 2018 at 8:49 AM Andrei Sereda <andrei@xxxxxxxxx> wrote:
> 
>> +1 (non-binding)
>> 
>> - Build and ran tests from c19e458d on MacOS X Oracle JDK 8, 9 and 10
>> - Checked signatures and checksums
>> - Release notes look good
>> 
>> Thank you, Julian!
>> 
>> 
>> On Wed, Dec 5, 2018 at 11:23 AM Michael Mior <mmior@xxxxxxxxxx> wrote:
>> 
>>> Interesting. I didn't realize the issue was Windows-only. Regardless,
>>> hopefully this will be resolved soon but I'm not worried about it
>> blocking
>>> the release.
>>> 
>>> --
>>> Michael Mior
>>> mmior@xxxxxxxxxx
>>> 
>>> 
>>> Le mer. 5 déc. 2018 à 11:00, Sergey Nuyanzin <snuyanzin@xxxxxxxxx> a
>>> écrit :
>>> 
>>>> Michael, thank you for link to the issue.
>>>> I have just tried to disable CassandraAdapterTest for jdk 9+ but only
>> on
>>>> Windows (as on Linux it works fine)
>>>> and it looks much better
>>>> builds on Windows with jdk8-11 ok
>>>> https://ci.appveyor.com/project/snuyanzin/calcite/builds/20789778
>>>> 
>>>> 
>>>> 
>>>> On Wed, Dec 5, 2018 at 6:55 PM Zoltan Haindrich <kirk@xxxxxx> wrote:
>>>> 
>>>>> Hello,
>>>>> 
>>>>> I've attached a patch for Hive to run all the tests against the RC -
>>> and
>>>>> the results seemed promising; but a null related query is failing
>> with
>>>>> incorrect results.
>>>>> 
>>>>> 
>>>> 
>>> 
>> https://github.com/apache/hive/blob/8e30b5e029570407d8a1db67d322a95db705750e/ql/src/test/queries/clientpositive/in_typecheck_mixed.q#L12
>>>>> The test seems to be broken by CALCITE-2604; but I feel that this
>> issue
>>>>> was hiding in the bushes - and might have just needed a more
>>>> sophisticated
>>>>> query prior to that patch.
>>>>> I've reproduced the issue in Calcite and opened CALCITE-2726 to
>> address
>>>> it.
>>>>> 
>>>>> cheers,
>>>>> Zoltan
>>>>> 
>>>>> 
>>>>> On 12/4/18 10:00 AM, Julian Hyde wrote:
>>>>>> Hi all,
>>>>>> 
>>>>>> I have created a build for Apache Calcite 1.18.0, release candidate
>>> 0.
>>>>>> 
>>>>>> Thanks to everyone who has contributed to this release.
>>>>>> With over 200 commits from 36 contributors, this is the largest
>>>>>> Calcite release ever!
>>>>>> You can read the release notes here:
>>>>>> 
>>>> 
>> https://github.com/apache/calcite/blob/branch-1.18/site/_docs/history.md
>>>>>> 
>>>>>> The commit to be voted upon:
>>>>>> 
>>>>> 
>>>> 
>>> 
>> http://git-wip-us.apache.org/repos/asf/calcite/commit/c19e458d2bdbd42dbd450143e0f41fabbfe4ec06
>>>>>> 
>>>>>> Its hash is c19e458d2bdbd42dbd450143e0f41fabbfe4ec06.
>>>>>> 
>>>>>> The artifacts to be voted on are located here:
>>>>>> 
>>>> 
>> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.18.0-rc0
>>>>>> 
>>>>>> The hashes of the artifacts are as follows:
>>>>>> src.tar.gz.sha256
>>>>>> 8931ccc08863e4fe394824ead306dc89a7a78a41f898303187a91b01a723cce6
>>>>>> 
>>>>>> A staged Maven repository is available for review at:
>>>>>> 
>>>> 
>> https://repository.apache.org/content/repositories/orgapachecalcite-1049
>>>>>> 
>>>>>> Release artifacts are signed with the following key:
>>>>>> https://people.apache.org/keys/committer/jhyde.asc
>>>>>> 
>>>>>> Please vote on releasing this package as Apache Calcite 1.18.0.
>>>>>> 
>>>>>> The vote is open for the next 72 hours (closing at 1am Pacific on
>>>> Friday)
>>>>>> and passes if a majority of at least three +1 PMC votes are cast.
>>>>>> 
>>>>>> [ ] +1 Release this package as Apache Calcite 1.18.0
>>>>>> [ ]  0 I don't feel strongly about it, but I'm okay with the
>> release
>>>>>> [ ] -1 Do not release this package because...
>>>>>> 
>>>>>> 
>>>>>> Here is my vote:
>>>>>> 
>>>>>> +1 (binding)
>>>>>> 
>>>>>> Julian
>>>>>> 
>>>>> 
>>>> 
>>>> 
>>>> --
>>>> Best regards,
>>>> Sergey
>>>> 
>>> 
>>