osdir.com


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: CALCITE-2458 Use of Kotlin for unit tests


Hello,

I would like to note that this change have also altered that now all tests in the core module are now compiled by the kotlin compiler.
As I think Calcite is still a java library: I think that it would be better to compile and run the main tests by the supported platform's tools - and probably move the kotlin tests into a separate submodule. Right now it is not possible to compile the core module's tests without kotlin support: because the only kotlin test which contains "hello world" have made into the CalcitesSuite.java.

regards,
Zoltan


On 9/24/18 11:43 PM, Vladimir Sitnikov wrote:
Thanks everybody for your comments.

I've received no strong objections so far, so I assume lazy consensus.
I've merged the PR in
https://git-wip-us.apache.org/repos/asf?p=calcite.git;a=commit;h=55d86646fe598d215bd53dbeac2bbbf32a9506f9

Vladimir