osdir.com


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [VOTE] Release calcite-avatica-go-3.2.0 (release candidate 0)


Thank you, Michael!

On 18/09/2018 12:35 AM, Michael Mior wrote:
Sorry for being slow again. I tried this again and all seems good.
Maintaining my +1 (binding)

--
Michael Mior
mmior@xxxxxxxxxx


Le jeu. 13 sept. 2018 à 22:22, Francis Chuang <francischuang@xxxxxxxxxx> a
écrit :

I updated HBase in the Boostport/hbase-phoenix-all-in-one image from
2.0.1 to 2.0.2 and was able to get the tests passing on my resource
starved VM.

Can you delete your existing copy of the hbase-phoenix-all-in-one image
and pull in the latest version?

On 13/09/2018 11:13 PM, Michael Mior wrote:
I'm happy to trust you that the test works although my machine has 16GB
RAM, it is a i5-2400. I'll try to look into this deeper later today, but
I'm still ok giving my +1.

--
Michael Mior
mmior@xxxxxxxxxx


Le mer. 12 sept. 2018 à 23:12, Francis Chuang <francischuang@xxxxxxxxxx>
a
écrit :

A few more things to try:
- Delete the hbase-phoenix-all-in-one:2.0-5.0 image and let
docker-compose redownload it
- Try running the tests again because sometimes running phoenix + hbase
in standalone mode in a docker container can be quite memory + cpu heavy

Francis

On 13/09/2018 12:57 PM, Francis Chuang wrote:
Hey Michael,

Thanks for confirming. How much memory and what CPU is in your machine?

I just ran the tests using docker-compose on 2 machines:
- An old Core i7 920 with 12GB of RAM using docker for windows in
hyper-v (the docker for windows VM is allocated 2GB of memory).
- A new Core i7 Kabylake with 32GB of RAM using docker in a Ubuntu VM
running on Virtual Box.

The tests also work correctly on Travis:
https://travis-ci.org/apache/calcite-avatica-go/builds/427109209

I think it's quite possible that the phoenix image does not have
access to enough memory to start correctly. Do you have another
machine you can test on?

I think the problem is probably in the Tephra (in Phoenix). Would you
be able to inspect the Phoenix container (you can start a shell by
running "docker exec -it $CONTAINER_ID sh")? There was someone who had
the same issue as well here:

http://mail-archives.apache.org/mod_mbox/phoenix-user/201611.mbox/%3CCAKD+54HvE3_Wh8oEuRVWP=bxR+VA0iMwDcuBRcn6=cGna4F+FQ@xxxxxxxxxxxxxx%3E
but his problem seems to be a config error.

Francis

On 13/09/2018 11:17 AM, Michael Mior wrote:
I just used Docker compose as mentioned in the docs.

--
Michael Mior
mmior@xxxxxxxxxx


Le mer. 12 sept. 2018 à 18:35, Francis Chuang
<francischuang@xxxxxxxxxx> a
écrit :

Hi Michael,

Thanks for giving the tests a shot! Can you try the following?

- Are the tests being run using the docker-compose.yml file or do you
have your own environment set up? If you did not use docker, can you
try
running the tests using docker to see if they work? To do that, just
run
"docker-compose up --build" from the root directory.
- If you have your own environment, can you post the version of
Phoenix
+ HBase being used?
- If you have Phoenix running in your own environment, were
transactions
enabled following the instructions here:
http://phoenix.apache.org/transactions.html?
- If that does not work, can you replace guava shipped with HBase
(11.0.2 for HBase 5.0) with Guava 13.0.1 (which is used by tephra) in
your $HBASE_PATH/lib folder?

Francis

On 13/09/2018 6:38 AM, Michael Mior wrote:
Thanks for rolling this so quickly Francis! I downloaded and
checked the
hash and signature and managed to build. I get the failures below
when
running tests.

calcite-avatica-go_1  | === RUN TestPhoenixCommittingTransactions
calcite-avatica-go_1  | --- FAIL: TestPhoenixCommittingTransactions
(46.24s)
calcite-avatica-go_1  | driver_test.go:95: error on exec CREATE
TABLE
test153678411465270855228 (
calcite-avatica-go_1 |                                         int
INTEGER
PRIMARY KEY
calcite-avatica-go_1  | )
TRANSACTIONAL=true: An error was encountered while processing your
request:
RuntimeException: org.apache.phoenix.shaded.org
.apache.thrift.TException:
Unable to discover transaction service. -> TException: Unable to
discover
transaction service.
calcite-avatica-go_1  | === RUN TestPhoenixRollingBackTransactions
calcite-avatica-go_1  | --- FAIL: TestPhoenixRollingBackTransactions
(46.12s)
calcite-avatica-go_1  |     driver_test.go:95: error on exec CREATE
TABLE
test153678416089522923246 (
calcite-avatica-go_1 |                                         int
INTEGER
PRIMARY KEY
calcite-avatica-go_1  | )
TRANSACTIONAL=true: An error was encountered while processing your
request:
RuntimeException: org.apache.phoenix.shaded.org
.apache.thrift.TException:
Unable to discover transaction service. -> TException: Unable to
discover
transaction service.

calcite-avatica-go_1  | === RUN TestPhoenixOptimisticConcurrency
calcite-avatica-go_1  | --- FAIL: TestPhoenixOptimisticConcurrency
(46.12s)
calcite-avatica-go_1  | driver_test.go:95: error on exec CREATE
TABLE
test15367842129113598722 (
calcite-avatica-go_1 |                                         id
INTEGER
PRIMARY KEY,
calcite-avatica-go_1 |                                         msg
VARCHAR,
calcite-avatica-go_1 |
  version
INTEGER
calcite-avatica-go_1  | )
TRANSACTIONAL=true: An error was encountered while processing your
request:
RuntimeException: org.apache.phoenix.shaded.org
.apache.thrift.TException:
Unable to discover transaction service. -> TException: Unable to
discover
transaction service.

calcite-avatica-go_1  | FAIL
calcite-avatica-go_1  | FAIL
github.com/apache/calcite-avatica-go/v3
186.298s
calcite-avatica-go_1  | ?
github.com/apache/calcite-avatica-go/v3/errors  [no test files]
calcite-avatica-go_1  | ?
github.com/apache/calcite-avatica-go/v3/generic [no test files]
calcite-avatica-go_1  | ?
github.com/apache/calcite-avatica-go/v3/hsqldb  [no test files]
calcite-avatica-go_1  | ?
github.com/apache/calcite-avatica-go/v3/internal        [no test
files]
calcite-avatica-go_1  | ?
github.com/apache/calcite-avatica-go/v3/message [no test files]
calcite-avatica-go_1  | ?
github.com/apache/calcite-avatica-go/v3/phoenix [no test files]

--
Michael Mior
mmior@xxxxxxxxxx


Le mar. 11 sept. 2018 à 05:17, Francis Chuang
<francischuang@xxxxxxxxxx>
a
écrit :

Hi all,

I have created a release for Apache Calcite Avatica Go 3.2.0,
release
candidate 0.

The release notes are available here:


https://github.com/apache/calcite-avatica-go/blob/master/site/_docs/go_history.md
The commit to be voted on:


http://git-wip-us.apache.org/repos/asf/calcite-avatica-go/commit/0a166d5f48dba88f5f3a0a1582b4ea7a994fff8c
The hash is 0a166d5f48dba88f5f3a0a1582b4ea7a994fff8c

The artifacts to be voted on are located here:


https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-go-3.2.0-rc0/
The hashes of the artifacts are as follows:

src.tar.gz 682C40E8 EBD5748B 12C61E5D FF42B02E 1A5FCED0 6C070E61
1872DFCC
A66104B5

Release artifacts are signed with the following key:
https://people.apache.org/keys/committer/francischuang.asc

Instructions for running the test suite is located here:


https://github.com/apache/calcite-avatica-go/blob/master/site/develop/avatica-go.md#testing
Please vote on releasing this package as Apache Calcite Avatica Go
3.2.0.
To run the tests without a Go environment, install docker and
docker-compose. Then, in the root of the release's directory, run:
docker-compose up --build

The vote is open for the next 72 hours and passes if a majority of
at least three +1 PMC votes are cast.

[ ] +1 Release this package as Apache Calcite Avatica Go 3.2.0
[ ]  0 I don't feel strongly about it, but I'm okay with the
release
[ ] -1 Do not release this package because...


Here is my vote:

+1 (binding)

Francis