osdir.com


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: CALCITE-2458 Use of Kotlin for unit tests


+0.5 I haven't used Kotlin but I've had enough exposure that I'm very
interested in the idea. The main reason for the lack of a +1 is a concern
that it may prove a barrier to new contributors but if others are for it,
it's the excuse I've been looking for to finally write some Kotlin. I think
test code is just the place to introduce something like this. Anything that
makes test code less verbose is a good way of encouraging more tests to be
written :)

--
Michael Mior
mmior@xxxxxxxxxx


Le lun. 17 sept. 2018 à 15:21, Vladimir Sitnikov <
sitnikov.vladimir@xxxxxxxxx> a écrit :

> Hi,
>
> I think it time for us to enable use of Kotlin in unit tests.
> There are lots of language features (e.g. name parameters, data classes,
> multiline strings, infix functions, nullability, smart casts, etc) that
> would make code simpler to read and write.
>
> Note: the change is related to use of Kotlin in test-code only.
> Kotlin use for production classes might require a bit more of thought (e.g.
> the set of dependencies, etc), so let's settle on Kotlin for tests first.
>
> More details can be found in:
> https://issues.apache.org/jira/browse/CALCITE-2458  (created Aug 8)
> PR: https://github.com/apache/calcite/pull/786 (created Aug 9)
>
> If no-one objects within a week, I'll assume lazy consensus and commit it.
>
> It might be nice to gather a bit more feedback on the change though. What
> do you think of the change?
>
> If you struggle what to say, you might find the below options useful:
>
> [ ] ++1: 'Wow! I like this! Let's do it!'
> [ ] +1: 'Let's do it!'
> [ ] +0.9: 'This is a cool idea and i like it'
>
> Vladimir
>