osdir.com


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Sqlline release


Thank you, Julian!

Kind regards,
Arina

On Sun, Sep 9, 2018 at 8:20 AM Sergey Nuyanzin <snuyanzin@xxxxxxxxx> wrote:

> Thank you very much for recognition and releasing sqlline
>
> did several checks on final version:
> - Bumped dependency in Apache Calcite  and compiled
> - Created custom command handler in calcite-csv-example, compiled and added
> via commandhandler and -ch, checked simple new commands
> - Created custom application configuration in calcite-csv-example
> - different queries and commands (found
> https://github.com/julianhyde/sqlline/issues/141 however it is also actual
> for previous versions)
>
>
> On Sun, Sep 9, 2018 at 7:35 AM Julian Hyde <jhyde@xxxxxxxxxx> wrote:
>
> > Turns out that Arina made *FOUR* PRs last night. (So much for the
> > weekend!) Thank you - I put them all in.
> >
> > Release sqlline-1.5.0 is now final[1], and the binaries should be
> > appearing on Maven Central in an hour or two.
> >
> > A big thanks to all of the contributors to this release but especially
> > to Sergey Nuyanzin (25 contributions) and Arina Ielchiieva (6
> > contributions). In recognition of your efforts, I have made you two
> > committers; see [2].
> >
> > Julian
> >
> > [1] https://github.com/julianhyde/sqlline/releases/tag/sqlline-1.5.0
> >
> > [2] https://github.com/julianhyde/sqlline#committers
> > On Sat, Sep 8, 2018 at 3:23 PM Julian Hyde <jhyde@xxxxxxxxxx> wrote:
> > >
> > > Thanks, Arina.
> > >
> > > I knew about the JDK 1.7 issue. For JDK 1.7 and 1.6, I ran with
> > > "-Ddocbkx.skip=true -Dhsqldb.version=2.3.4" and the build succeeded.
> > >
> > > I saw your two PRs; thanks for these; I will merge them in and cut a
> > > new release candidate.
> > >
> > > Julian
> > >
> > > On Sat, Sep 8, 2018 at 7:03 AM Arina Yelchiyeva
> > > <arina.yelchiyeva@xxxxxxxxx> wrote:
> > > >
> > > > Checked from the scratch branch:
> > > > 1. Ran unit tests:
> > > > - JDK8 - all unit tests pass.
> > > > - JDK7 - unable to run unit tests, fails due to upgrade to
> > > > <hsqldb.version>2.4.1</hsqldb.version>.
> > > > [ERROR] java.lang.UnsupportedClassVersionError:
> > > > org/hsqldb/jdbc/JDBCDatabaseMetaData : Unsupported major.minor
> version
> > 52.0
> > > >
> > > > 2. Connected to Apache Drill:
> > > > - custom application config (custom info message, excluded commands,
> > > > session options etc).
> > > > - checked custom application reset
> > > > - checked connection / re-connection / close
> > > > - checked proper exceptions are displayed when using incorrect url /
> > driver
> > > > - ran random queries
> > > > - checked randomly commands / session options
> > > >
> > > > Kind regards,
> > > > Arina
> > > >
> > > >
> > > >
> > > > On Sat, Sep 8, 2018 at 8:25 AM Julian Hyde <jhyde@xxxxxxxxxx> wrote:
> > > >
> > > > > We have a release candidate for sqlline-1.5.0, based on
> > > > >
> > > > >
> >
> https://github.com/julianhyde/sqlline/commit/73d5974b6e694154bc47172f65d56ae47aa536aa
> > > > > .
> > > > >
> > > > > This is not an Apache release, so there is no .tar.gz to look at,
> and
> > > > > no formal vote, but I'd appreciate if one or two people look it
> over.
> > > > > The jar is staged at maven central, so you can try it out by
> changing
> > > > > 1.4.0 to 1.5.0 in your project's pom.xml.
> > > > >
> > > > > If there are no objections I'll make the release official tomorrow.
> > > > >
> > > > > Julian
> > > > >
> > > > > On Thu, Sep 6, 2018 at 11:36 AM Julian Hyde <jhyde@xxxxxxxxxx>
> > wrote:
> > > > > >
> > > > > > We’re very close to an RC for sqlline-1.5.0. Arina is working to
> > > > > finalize https://github.com/julianhyde/sqlline/issues/106.
> > > > > >
> > > > > > This is going to be the biggest sqlline release for a long time.
> > > > > (Special thanks to Sergey Nuyanzin for many, many high-quality
> PRs.)
> > > > > >
> > > > > > If you’re in the Calcite community and would like to help, please
> > give
> > > > > the new sqlline a try and log any bugs you see. Get the latest
> > sqlline
> > > > > master, run ‘mvn install’, then in your Calcite pom.xml change
> > > > > sqlline.version from 1.4.0 to 1.5.0-SNAPSHOT. You may need to ‘rm
> > > > > target/fullclasspath.txt’ before you run ‘./sqlline’.
> > > > > >
> > > > > > Julian
> > > > > >
> > > > > >
> > > > > > On Sep 4, 2018, at 2:00 PM, Julian Hyde <jhyde@xxxxxxxxxx>
> wrote:
> > > > > >
> > > > > > We said first week of September. Now it’s the first release of
> > > > > September. I think I can make a release candidate for sqlline-1.5.0
> > in the
> > > > > next few days. (As a non-Apache project, there is no formal vote
> for
> > > > > releases, but I welcome feedback.)
> > > > > >
> > > > > > There are few issues/PRs[1][2][3] that require jline3, and jline3
> > only
> > > > > works on JDK 8 and higher. I propose to take those PRs immediately
> > AFTER
> > > > > this release. Thus, sqlline-1.5 will be the last sqlline release
> that
> > > > > supports JDK 1.6 or 1.7.
> > > > > >
> > > > > > Julian
> > > > > >
> > > > > > [1] https://github.com/julianhyde/sqlline/issues/105
> > > > > >
> > > > > > [2] https://github.com/julianhyde/sqlline/pull/115
> > > > > >
> > > > > > [3] https://github.com/julianhyde/sqlline/issues/73
> > > > > >
> > > > > >
> > > > > > On Aug 19, 2018, at 10:22 AM, Sergey Nuyanzin <
> snuyanzin@xxxxxxxxx
> > >
> > > > > wrote:
> > > > > >
> > > > > > Thank you for a good news.
> > > > > > I've added a new PR based on this #86 and I guess in one or two
> > days will
> > > > > > add one more
> > > > > >
> > > > > > On Sun, Aug 19, 2018 at 7:06 PM Julian Hyde <jhyde@xxxxxxxxxx>
> > wrote:
> > > > > >
> > > > > > I’ve pushed PR #86...
> > > > > >
> > > > >
> >
> https://github.com/julianhyde/sqlline/commit/8e0061f113d89a11ca03f4b48eda3340fd00375c
> > > > > > <
> > > > > >
> > > > >
> >
> https://github.com/julianhyde/sqlline/commit/8e0061f113d89a11ca03f4b48eda3340fd00375c
> > > > > >
> > > > > >
> > > > > >
> > > > > > I’ll try to get to your remaining PRs in the next few days. Keep
> > up the
> > > > > > good work!
> > > > > >
> > > > > > Julian
> > > > > >
> > > > > >
> > > > > > On Aug 18, 2018, at 11:04 AM, Sergey Nuyanzin <
> snuyanzin@xxxxxxxxx
> > >
> > > > > >
> > > > > > wrote:
> > > > > >
> > > > > >
> > > > > > Julian,
> > > > > > thank you very much for merging
> > > > > >
> > > > > > about PR on which I would like to build to add one more
> > improvement:
> > > > > > currently there is only one
> > > > > > https://github.com/julianhyde/sqlline/pull/86 (commit 340c3b1 )
> > > > > >
> > > > > > Sergey and others, Is first week of September still a good
> > timeframe
> > > > > >
> > > > > > for
> > > > > >
> > > > > > release?
> > > > > > for me yes it is good
> > > > > >
> > > > > >
> > > > > > On Sat, Aug 18, 2018 at 8:14 PM Julian Hyde <jhyde@xxxxxxxxxx>
> > wrote:
> > > > > >
> > > > > > Sergey,
> > > > > >
> > > > > > I see a lot of pull requests for sqlline coming in from you…
> which
> > is
> > > > > > excellent! You have said in a previous thread that it would be
> > helpful
> > > > > >
> > > > > > if
> > > > > >
> > > > > > some of them are merged to master because you want to build on
> > that. So,
> > > > > > could you give me an ordered list of PR numbers that are ready to
> > merge?
> > > > > > That would be helpful for me as I try to work through the backlog
> > and
> > > > > >
> > > > > > merge
> > > > > >
> > > > > > them.
> > > > > >
> > > > > > Sergey and others, Is first week of September still a good
> > timeframe for
> > > > > > release?
> > > > > >
> > > > > > Julian
> > > > > >
> > > > > >
> > > > > > On Aug 9, 2018, at 1:35 AM, Julian Hyde <jhyde.apache@xxxxxxxxx>
> > > > > >
> > > > > > wrote:
> > > > > >
> > > > > >
> > > > > > Let’s wait about a month then. Target the first week in
> September.
> > > > > >
> > > > > > (Good to see all these new features Sergey... keep them coming!)
> > > > > >
> > > > > > Julian
> > > > > >
> > > > > > On Aug 7, 2018, at 11:44 AM, Sergey Nuyanzin <
> snuyanzin@xxxxxxxxx>
> > > > > >
> > > > > > wrote:
> > > > > >
> > > > > >
> > > > > > +1 for release
> > > > > > at the same time I am ok to wait about a month
> > > > > > (I have a few ideas about some more improvements)
> > > > > >
> > > > > > On Tue, Aug 7, 2018 at 5:29 AM Julian Hyde <julianhyde@xxxxxxxxx
> >
> > > > > >
> > > > > > wrote:
> > > > > >
> > > > > >
> > > > > > (Forgive the cross-posting. The sqlline dev list isn’t very
> active,
> > > > > >
> > > > > > and
> > > > > >
> > > > > > many of the sqlline community are in the calcite community.
> Please
> > > > > >
> > > > > > reply to
> > > > > >
> > > > > > calcite dev only.)
> > > > > >
> > > > > > There have been a number of enhancements to sqlline recently[1]
> > > > > >
> > > > > > (thanks,
> > > > > >
> > > > > > Sergey!). Is it time for a release of sqlline? Or should we plan
> to
> > > > > >
> > > > > > have a
> > > > > >
> > > > > > release in say a month, to give people time to add more features.
> > > > > >
> > > > > > Julian
> > > > > >
> > > > > > [1] https://github.com/julianhyde/sqlline/commits/master
> > > > > >
> > > > > > --
> > > > > > You received this message because you are subscribed to the
> Google
> > > > > >
> > > > > > Groups
> > > > > >
> > > > > > "sqlline-dev" group.
> > > > > > To unsubscribe from this group and stop receiving emails from it,
> > > > > >
> > > > > > send
> > > > > >
> > > > > > an
> > > > > >
> > > > > > email to sqlline-dev+unsubscribe@xxxxxxxxxxxxxxxx.
> > > > > > To post to this group, send email to
> sqlline-dev@xxxxxxxxxxxxxxxx.
> > > > > > To view this discussion on the web visit
> > > > > >
> > > > > >
> > > > > >
> > > > >
> >
> https://groups.google.com/d/msgid/sqlline-dev/32DBFC47-F2D7-4DB4-9B32-3F36B54296C4%40gmail.com
> > > > > >
> > > > > > <
> > > > > >
> > > > > >
> > > > > >
> > > > >
> >
> https://groups.google.com/d/msgid/sqlline-dev/32DBFC47-F2D7-4DB4-9B32-3F36B54296C4%40gmail.com?utm_medium=email&utm_source=footer
> > > > > >
> > > > > >
> > > > > > .
> > > > > > For more options, visit https://groups.google.com/d/optout.
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Best regards,
> > > > > > Sergey
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Best regards,
> > > > > > Sergey
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Best regards,
> > > > > > Sergey
> > > > > >
> > > > > >
> > > > > >
> > > > >
> >
>
>
> --
> Best regards,
> Sergey
>