OSDir


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: using "fakes" in unit tests


Pls take a look at PR 715 <https://github.com/apache/calcite/pull/715> and
let me know what you think.

I'm not sure if one should reuse existing dataset
<https://github.com/vlsi/calcite-test-dataset> (zips.json ~ 3MB), smaller
one or manually populate the database. If former, .json should be present
somewhere in classpath most likely distributed with calcite source.

Feedback is welcome.

On Tue, May 29, 2018 at 8:25 AM, Michael Mior <mmior@xxxxxxxxxx> wrote:

> I'd definitely be open to this if we can get something stable working.
> Anything which gets better regular test coverage for the adapters is great
> in my books.
>
> --
> Michael Mior
> mmior@xxxxxxxxxx
>
>
>
> Le lun. 28 mai 2018 à 23:47, Andrei Sereda <andrei@xxxxxxxxx> a écrit :
>
> > Hello,
> >
> > Current IT tests require manual startup and seeding of data-sources
> (Mongo,
> > ES, Geode etc.) from separate git project (see calcite-test-dataset
> > <https://github.com/vlsi/calcite-test-dataset> ). While useful they
> force
> > developer to bootstrap additional environment on his own and don't work
> by
> > default (unless properly initialized).
> >
> > Would you consider using "fake" (in memory) data-sources for unit tests
> > like:
> > - Fongo <https://github.com/fakemongo/fongo>  for Mongo
> > - TestNode
> > <
> > https://github.com/dremio/dremio-oss/blob/master/
> plugins/elasticsearch/src/test/java/org/elasticsearch/
> node/ElasticTestNode.java
> > >
> > for ElasticSearch
> >
> > I'm not proposing to stop using IT but rather having a better coverage
> for
> > unit tests (with fakes)
> >
> > Interesting to hear your opinion.
> >
> > Regards,
> > Andrei.
> >
>