osdir.com

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] brooklyn-ui pull request #113: Fix template overrides - decorate `script` di...


GitHub user ahgittin opened a pull request:

    https://github.com/apache/brooklyn-ui/pull/113

    Fix template overrides - decorate `script` directive to prevent re-overriding of templates

    by default `<script>` will install to template cache whenever it is processed as a directive.
    this decorates it to be no-op if there is already something in the cache with that name,
    allowing programmatic overrides of templates configured using `<script id="...">` notation.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ahgittin/brooklyn-ui fix-template-overrides

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-ui/pull/113.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #113
    
----
commit 722d2515edb9ed7c6322191cf5477d19d2b27f0a
Author: Alex Heneveld <alex.heneveld@...>
Date:   2018-11-22T11:07:20Z

    install template to cache earlier
    
    not really needed, but is consistent with how done elsewhere,
    and allows override

commit b04423b169e0d9a749ace79ccd446b4c6f3bb232
Author: Alex Heneveld <alex.heneveld@...>
Date:   2018-11-22T11:07:47Z

    decorate `script` directive to prevent re-overriding of templates
    
    by default `<script>` will install to template cache whenever it is processed as a directive.
    this decorates it to be no-op if there is already something in the cache with that name,
    allowing programmatic overrides of templates configured using `<script id="...">` notation.

----


---