osdir.com

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] brooklyn-ui pull request #108: improve logic and ui for inferring bundle and...


Github user tbouron commented on a diff in the pull request:

    https://github.com/apache/brooklyn-ui/pull/108#discussion_r232966239
  
    --- Diff: ui-modules/blueprint-composer/app/components/catalog-saver/catalog-saver.modal.template.html ---
    @@ -57,19 +60,17 @@ <h3 class="modal-title">{{getTitle()}}</h3>
                     <label class="control-label">Bundle ID</label>
                     <div class="input-group">
                         <span class="input-group-addon">catalog-bom-</span>
    -                    <input ng-model="config.bundle" ng-disabled="state.saving" class="form-control" placeholder="E.g my-bundle" name="bundle" required ng-pattern="state.pattern" autofocus />
    +                    <input ng-model="config.bundle" ng-disabled="state.saving" class="form-control" name="bundle" ng-pattern="state.pattern" autofocus placeholder="{{ config.name | bundlize }}"/>
                     </div>
                     <p class="help-block" ng-show="form.bundle.$invalid">
    -                    <span ng-if="form.bundle.$error.required">You must specify a bundle ID</span>
                         <span ng-if="form.bundle.$error.pattern">The bundle ID can contains only letters, numbers as well a the following characters: <code>.</code>, <code>-</code> and <code>_</code></span>
                     </p>
                 </div>
     
                 <div class="form-group" ng-class="{'has-error': form.symbolicName.$invalid}">
                     <label class="control-label">Blueprint symbolic name</label>
    -                <input ng-model="config.symbolicName" ng-disabled="state.saving" class="form-control" placeholder="E.g my-catalog-id" name="symbolicName" required ng-pattern="state.pattern" autofocus />
    +                <input ng-model="config.symbolicName" ng-disabled="state.saving" class="form-control" name="symbolicName" ng-pattern="state.pattern" autofocus placeholder="{{ config.name | bundlize }}"/>
    --- End diff --
    
    I get that `config.name` is required but until you set it, there will be no placeholder. So you should do `{{(config.name | bundlize) || 'E.g my-catalog-id'}}`


---