osdir.com


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] brooklyn-ui pull request #107: Use checkboxes for blueprint type in save mod...


Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/brooklyn-ui/pull/107#discussion_r232604315
  
    --- Diff: ui-modules/blueprint-composer/app/components/catalog-saver/catalog-saver.modal.template.html ---
    @@ -72,16 +72,24 @@ <h3 class="modal-title">{{getTitle()}}</h3>
                         <span ng-if="form.symbolicName.$error.required">You must specify a blueprint symbolic name</span>
                         <span ng-if="form.symbolicName.$error.pattern">The blueprint symbolic name can contains only letters, numbers as well a the following characters: <code>.</code>, <code>-</code> and <code>_</code></span>
                     </p>
    -            </div>
    +            </div>>
     
    -            <div class="form-group" ng-class="{'has-error': form.itemType.$invalid}">
    +            <div class="form-group">
                     <label class="control-label">Blueprint type</label>
    -                <select class="form-control" name="itemType" ng-options="type.id as type.label for type in TYPES" ng-model="config.itemType" ng-disabled="state.saving" required >
    -                </select>
    -                <p class="help-block" ng-show="form.itemType.$invalid">
    -                    <span ng-if="form.itemType.$error.required">You must specify a blueprint type</span>
    -                </p>
    +                <div class="checkbox">
    +                    <label>
    +                        <input ng-model="config.template" ng-disabled="state.saving" name="template" type="checkbox" ng-change="config.template && (config.entity = !config.template)" />
    +                        Save this as a template displayable in quick-launch
    --- End diff --
    
    could text be:  `Save as "template" which can be used as an editable starting point for other blueprints or quick-launched directly`  if that is too long we could simply show `Template (i)` with help popup showing the longer text.


---