osdir.com


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] brooklyn-ui pull request #94: Composer recent and filters


Github user tbouron commented on a diff in the pull request:

    https://github.com/apache/brooklyn-ui/pull/94#discussion_r229348023
  
    --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js ---
    @@ -110,6 +110,38 @@ export function catalogSelectorSearchFilter() {
         }
     }
     
    +export function catalogSelectorFiltersFilter() {
    +    // compute counts and apply active filters;     
    +    // this is called by the view after filtering based on search,
    +    // so filters can adjust based on number of search results
    +    return function (items, $scope) {
    --- End diff --
    
    Passing scope around is a bad idea for performances, you should pass each individual parameter, or an object containing all them instead.


---