OSDir


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] brooklyn-ui pull request #94: Composer recent and filters


Github user tbouron commented on a diff in the pull request:

    https://github.com/apache/brooklyn-ui/pull/94#discussion_r228905287
  
    --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js ---
    @@ -127,15 +135,15 @@ function controller($scope, $element, $q, $uibModal, $log, $templateCache, palet
         $scope.getPlaceHolder = function () {
             return 'Search';
         };
    -
    +    
         $scope.isLoading = true;
     
         $scope.$watch('search', () => {
             $scope.freeFormTile = {
                 symbolicName: $scope.search,
                 name: $scope.search,
                 displayName: $scope.search,
    -            supertypes: [$scope.family.superType]
    +            supertypes: ($scope.family ? [ $scope.family.superType ] : []),
    --- End diff --
    
    `scope.family` is marked as required in the directive specification, you shouldn't need that


---