[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] brooklyn-ui pull request #69: Fix a couple issues with composer spec/config ...

GitHub user ahgittin opened a pull request:


    Fix a couple issues with composer spec/config editor

    * more on generics
    * multiple updates to values / scope variable dereferencing

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ahgittin/brooklyn-ui fix-ui

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #69
commit 0afa7e77feeed35190ee10a43a3fd186d524f2f7
Author: Alex Heneveld <alex.heneveld@...>
Date:   2018-09-13T10:19:44Z

    fix more generics issue in UI wizard, for entity spec selection

commit cd2ac803f1fab71505b7400f86e9de630ba48314
Author: Alex Heneveld <alex.heneveld@...>
Date:   2018-09-13T10:48:27Z

    custom widgets should not copy scope values from parent
    but rather reference them explicitly.  copying scope means if the parent changes that var, which it does e.g. for `config`, the child's scope value becomes disconnected.