[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] brooklyn issue #20: include instructions for building outwith source control

Github user ahgittin commented on the issue:

    I think any built artifact should include information on its provenance, so requiring a user to supply that metadata could be argued as a good thing!
    I don't have stats to back this up but I'd make a tidy wager that Apache source releases are rarely if ever downloaded.  I know the source code is the _official_ release, but I see that as an object of record which should have _clear_ and _reliable_ build instructions but no requirement to make it _easy_ to build.  (And as you know very well it is _not_ easy to build, with rpm and npm and go etc etc, so a couple extra build arguments is relatively small!)
    Also there is no super easy fix that I'm aware of.  The build _is_ broken from a non-SCM source copy, and this PR fixes that problem.  I'd love it if there's a better way that allows `buildNumber` to get a default value, but that can be another PR that reverts this.  Desire for that shouldn't block this.
    To answer your final question these variables result in the SHA1 commit ID of each source code project to be encoded in the generated JARs and other artifacts, and served up in the REST API.  I would strongly -1 omitting that as it's one of the first things to check when troubleshooting!