[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] brooklyn-server pull request #989: LogWatcher - don't change log level if no...


GitHub user ahgittin opened a pull request:

    https://github.com/apache/brooklyn-server/pull/989

    LogWatcher - don't change log level if not needed

    prevents the logs from missing useful output if testing for a higher-level message,
    useful when investigating tests, esp SoftwareProcessStopsDuringStartTest.testStopDuringProvisionWaitsForCompletion where the log messages we want aren't showing because we reset it to warn.
    
    also use try-close syntax for LogWatcher.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ahgittin/brooklyn-server fix-tests-and-log-watcher

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/989.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #989
    
----
commit 6d42fb35234b82c32ea96fa25885d0942673ddda
Author: Alex Heneveld <alex.heneveld@...>
Date:   2018-09-11T10:36:48Z

    LogWatcher don't change log level if not needed
    
    prevents the logs from missing useful output if testing for a higher-level message,
    useful when investigating tests.
    
    also use try-close syntax for LogWatcher.

----


---