[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] brooklyn-ui pull request #66: recognize memberSpec anywhere, and refresh blu...


Github user tbouron commented on a diff in the pull request:

    https://github.com/apache/brooklyn-ui/pull/66#discussion_r213275020
  
    --- Diff: ui-modules/blueprint-composer/app/components/util/model/entity.model.js ---
    @@ -19,9 +19,10 @@
     import {Issue} from './issue.model';
     import {Dsl, DslParser} from './dsl.model';
     
    -const MEMBERSPEC_REGEX = /^(\w+\.)+[mM]ember[sS]pec$/;
    -const FIRST_MEMBERSPEC_REGEX = /^(\w+\.)+first[mM]ember[sS]pec$/;
    -const ANY_MEMBERSPEC_REGEX = /^(\w+\.)+(first)?[mM]ember[sS]pec$/;
    +const MEMBERSPEC_REGEX = /^(\w+\.)*[mM]ember[sS]pec$/;
    +const FIRST_MEMBERSPEC_REGEX = /^(\w+\.)*first[mM]ember[sS]pec$/;
    +// TODO ideally we'd just look at type EntitySpec, not key name, but for now look at keyname, anything ending memberSpec
    --- End diff --
    
    True. Ideally, we would like to use only the type. My comment was more to explain why we do it rather than asking for a change


---