[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] brooklyn-ui pull request #66: recognize memberSpec anywhere, and refresh blu...


Github user tbouron commented on a diff in the pull request:

    https://github.com/apache/brooklyn-ui/pull/66#discussion_r213274160
  
    --- Diff: ui-modules/blueprint-composer/app/views/main/yaml/yaml.state.js ---
    @@ -46,6 +46,7 @@ function yamlStateController($scope, $rootScope, $timeout, blueprintService, brS
     
                 try {
                     blueprintService.setFromYaml(cm.getValue(), true);
    +                blueprintService.refreshBlueprintMetadata();
    --- End diff --
    
    Hum I see but I think it could be achieved differently. In any case, `blueprintService.refreshBlueprintMetadata()` does a couple of network request. However, this code is triggered on every keypress, that will probably degrade this user experience.
    
    We probably want to revisit this by adding a debounce but I don't think it's a good idea to add this in the current form


---