[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] brooklyn-ui pull request #63: Fix bug with the DSL editor/viewer


GitHub user tbouron opened a pull request:

    https://github.com/apache/brooklyn-ui/pull/63

    Fix bug with the DSL editor/viewer

    This fixes 2 bugs:
    1. When adding a DSL for an entity spec, The DSL editor "Done" button was not redirecting to the spec editor. This was due to the previous param object being modified later on by the `ui-router`. Creating a deep copy of the object avoid this
    2. The DSL viewer was throwing an error while getting the name of the entity for DSL like `$brooklyn:self()` or `$brooklyn:parent()`. This is fixed by looking up directly for the relationships if the DSL are of that form

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tbouron/brooklyn-ui fix/dsl-editor

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-ui/pull/63.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #63
    
----
commit 39f8dbb94f1293b0a0c3f4001c81ac7195b93c68
Author: Thomas Bouron <thomas.bouron@...>
Date:   2018-08-20T15:10:15Z

    Fix bug with the DSL editor/viewer

----


---