[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] brooklyn-server issue #969: Add registered types test


Github user duncangrant commented on the issue:

    https://github.com/apache/brooklyn-server/pull/969
  
    @ahgittin in response to your comment https://github.com/apache/brooklyn-server/pull/969#issuecomment-396177108 I have removed that commit from the PR as I wasn't really comfortable with it either.  The reason I wanted to make that change was just to simplify the function in  terms of size and readability.  That's actually why I added the tests - to try to get some sort of control of the function.
    I don't see much value in adding a comment of the form - would like to simplify this but too high risk.


---