[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] brooklyn-server pull request #969: Add registered types test

GitHub user duncangrant opened a pull request:


    Add registered types test

    This PR follows on from #968 
    It adds 2 commits.  The first adds tests for the functionality fixed in #968 
    The second changes the logic in #968 in a way that I think is equivalent but I haven't managed to add the requisite test coverage to prove this.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/duncangrant/brooklyn-server add-registered-types-test

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #969
commit 066cbbf2f70cb9b7e4b79a6eeb29bf87422dd2f6
Author: Alex Heneveld <alex.heneveld@...>
Date:   2018-06-01T23:29:02Z

    does a yaml parse and compares the hash of the result when checking plan equivalence
    means that the same plan entered twice but with different comments, spacing, quotations etc,
    will not result in an error.  it only treats a plan as non-equivalent if their yaml is different
    after a deserialize-then-serialize cycle.  previously a catalog push for an already-present
    non-snapshot plan would fail unless the plan was identical up to a trim.  now it only fails if
    the objects are different.

commit c5e4e2993e8f2448286cbf08295cd7eebb006daf
Author: Duncan Grant <duncan.grant@...>
Date:   2018-06-05T15:24:23Z

    Add tests to RegisteredTypes.arePlansEquivilant
    Hopefully these show that we now ignore things like comments and strings
    with surrounding quotes

commit e6dee4e591cb2d14acb24a9270a01d2c4bbf5e4b
Author: Duncan Grant <duncan.grant@...>
Date:   2018-06-05T15:33:05Z

    Refactor to remove duplicate checks