osdir.com

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] brooklyn-server pull request #967: add an /applications/details endpoint whi...


Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/967#discussion_r192680963
  
    --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/ApplicationResource.java ---
    @@ -106,7 +112,16 @@
         @Context
         private UriInfo uriInfo;
     
    -    private EntityDetail fromEntity(Entity entity) {
    +    private EntitySummary fromEntity(Entity entity, boolean includeTags, int detailDepth, List<String> extraSensorGlobs, List<String> extraConfigGlobs) {
    +        if (detailDepth==0) {
    --- End diff --
    
    If `detailDepth==0`, it will ignore the `extraSensorGlobs` and `extraConfigGlobs`. That doesn't feel intuitive - is it deliberate? I interpreted "with references to children but not their details" as meaning we'd see the entity ids, but we wouldn't have a record for them.
    
    The deliberate behaviour for negative depth is also not intuitive (i.e. will contradict what a maintainer thinks 'depth' means) and subtle.


---