OSDir


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] brooklyn-server pull request #964: Persistence efficiency do less: don't per...


Github user geomacy commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/964#discussion_r191382888
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/PeriodicDeltaChangeListener.java ---
    @@ -527,7 +536,35 @@ private static String limitedCountString(Collection<?> items) {
         public synchronized void onManaged(BrooklynObject instance) {
             if (LOG.isTraceEnabled()) LOG.trace("onManaged: {}", instance);
             onChanged(instance);
    +        addReferencedObjects(instance);
    +    }
    +
    +    private void addReferencedObjects(BrooklynObject instance) {
    --- End diff --
    
    Could this be called something different to distinguish it from the `addReferencedObjects` at 365, to highlight the different use?   What do you think - `addReferencedObjectsForInitialPersist` or something?


---