osdir.com

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] brooklyn-docs issue #251: Add ApacheCon logo button to landing page


Github user tbouron commented on the issue:

    https://github.com/apache/brooklyn-docs/pull/251
  
    @geomacy LGTM.
    
    While this is very nice, I took the liberty to play a bit with it and ended up with this:
    ![screencapture-127-0-0-1-4000-2018-04-17-16_44_32](https://user-images.githubusercontent.com/2082759/38880866-a15f0bb4-425e-11e8-9df7-91948d14b063.png)
    
    That way, a user can close the "notification" if they don't want to see it. Tell me if you like that and I can commit on top of yours. Otherwise, happy to merge as it is.


---