[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Does NeedsRunner work on parameterized tests?

Ok, this is worrying - we're silently skipping some important test suites. Does anyone know what might be causing us to skip them?

On Mon, Dec 17, 2018 at 5:03 PM Kenneth Knowles <kenn@xxxxxxxxxx> wrote:
Flipping through the latest Java PreCommit Cron, it does look like NeedsRunner tests within the Parameterized sub-suites of TextIOReadTest are not executed.


On Sat, Dec 15, 2018 at 12:16 PM Reuven Lax <relax@xxxxxxxxxx> wrote:

I tried to switch one of our tests (AvroIOTest) over to be a parameterized test. However after doing so, I cannot get the NeedsRunner tests to execute! All attempts fail with the following:

No tests found for given includes: [org.apache.beam.sdk.io.AvroIOTest](filter.includeTestsMatching)

I also can't find evidence that Jenkins will execute this either.

Am I missing something, or do our NeedsRunner tests no longer work for parameterized tests? If the latter this is concerning, as there are a number of NeedsRunner paramaterized tests in our codebase (e.g. the TextIO tests).