[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Spotless broken on master

The equivalent target to run should be "check" - see https://beam.apache.org/contribute/

On Wed, Sep 12, 2018 at 6:01 AM Ismaël Mejía <iemejia@xxxxxxxxx> wrote:
Thanks for pointing this out Andrew (and sorry for the inconvenience).
This is indeed a non intuitive behavior of our build system (at least
for someone coming from maven):

This one checks spotless:

    ./gradlew clean build -p sdks/java/io/kinesis

This one does not:

    ./gradlew clean test -p sdks/java/io/kinesis

I am wondering if we should align them to avoiding this kind of issues
in the future, and also what is the closest equivalent of the old ‘mvn
clean verify -Prelease -pl ...’ to validate a specific module locally
to avoid running the full build for a minor case like this one but
without the fear of breaking stuff.
On Tue, Sep 11, 2018 at 11:55 PM Andrew Pilloud <apilloud@xxxxxxxxxx> wrote:
> I don't think spotless is included in the default test target. Jenkins runs a more expanded ':javaPreCommit' gradle target.
> Andrew
> On Tue, Sep 11, 2018 at 2:32 PM Ismaël Mejía <iemejia@xxxxxxxxx> wrote:
>> Mmm this is weird, I tested this locally and passed without issue, I
>> am wondering how could this happen.
>> Thanks anyway for the quick fix.