osdir.com

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Running post-commit tests on every PR


Hello everyone,

Rui suggested to run post-commit tests on every pull request. 

Lets utilize this forked thread to discuss this suggestion.

Best regards,
--Mikhail


On Wed, Jul 11, 2018 at 4:25 PM Mikhail Gryzykhin <migryz@xxxxxxxxxx> wrote:
Hi Rui,

I would suggest to start another thread for that discussion.

Lets keep this discussion focused on automated JIRA tickets creation.

--Mikhail


On Wed, Jul 11, 2018 at 4:12 PM Rui Wang <ruwang@xxxxxxxxxx> wrote:
Maybe this is also a good thread to start the discussion that if we want to enforce postcommit test for every PR. 

Can we afford the cost of longer waiting time to catch potential bugs? 

-Rui 

On Wed, Jul 11, 2018 at 4:04 PM Mikhail Gryzykhin <migryz@xxxxxxxxxx> wrote:
That's a valid point. 

Unfortunately, the JiraTestResultReporter plugin does not have features to dynamically assign owners. Additionally, I don't think it is always easy to find proper owner for post-commit tests at first glance, since they usually cover broad specter of issues.

My assumption is that we need someone to triage new issues. 

Ideally, any contributor, who sees failing test, should check unassigned tickets and either do triage, or assign them to someone who can. I strongly encourage this approach.

We have couple other ready-made options to consider:
1. We can configure JIRA component owner who would be assigned to created tickets.
2. JiraTestReporterPlugin can assign tickets to specific user. This is configured per Jenkins job. We can utilize this if someone volunteers.
3. Dynamic assignment will most likely require custom solution.

--Mikhail


On Wed, Jul 11, 2018 at 3:34 PM Andrew Pilloud <apilloud@xxxxxxxxxx> wrote:
Hi Mikhail,

I like the proposal! Hopefully this can replace the constant stream of build failure emails. I noticed one detail seems to be missing:  How will new issues be assigned to the proper owner? Will the tool do this automatically or will we need someone to triage new issues?

Andrew

On Wed, Jul 11, 2018 at 3:07 PM Mikhail Gryzykhin <migryz@xxxxxxxxxx> wrote:
Hi everyone,

I want to add an automatic JIRA tickets creation for failing post-commit tests.

I wrote up design proposal doc with more details on this:

Quick summary:
I suggest to utilize JiraTestResultReporter plugin. 
Since this plugin is not installed on our Jenkins yet, we have to request to Infra team to add it.

Please, comment if this approach sounds good to you.

Best regards,
--Mikhail