[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [DISCUSS] [BEAM-4126] Deleting Maven build files (pom.xml) grace period?

Actually, it hasn't been reviewed yet. Here is the PR: https://github.com/apache/beam/pull/5571

On Mon, Jul 9, 2018 at 4:16 PM Lukasz Cwik <lcwik@xxxxxxxxxx> wrote:
Thats great, I have a PR here that has been reviewed: https://github.com/apache/beam/pull/5571

Will merge.

On Mon, Jul 9, 2018 at 4:15 PM Mark Liu <markliu@xxxxxxxxxx> wrote:
The work that moving Dataflow build off Maven pom is done in Google internal, so this should no longer be the blocker for pom deletion on Beam. 

Considering it's been two weeks after 2.5 release, I propose to resume Maven pom cleanup if no known blockers.


On Tue, Jun 19, 2018 at 9:52 AM Kenneth Knowles <klk@xxxxxxxxxx> wrote:
-user@ for misc. progress reporting

I took a look at it yesterday. Learned a lot, made some progress that turns out to just be general goodness, and left comment on the JIRA.

On Mon, Jun 18, 2018 at 6:37 PM Lukasz Cwik <lcwik@xxxxxxxxxx> wrote:
Any updates on BEAM-4512?

On Mon, Jun 11, 2018 at 1:42 PM Lukasz Cwik <lcwik@xxxxxxxxxx> wrote:
Thanks all, it seems as though only Google needs the grace period. I'll wait for the shorter of BEAM-4512 or two weeks before merging https://github.com/apache/beam/pull/5571

On Wed, Jun 6, 2018 at 8:29 PM Kenneth Knowles <klk@xxxxxxxxxx> wrote:

Definitely a good opportunity to decouple your build tools from your dependencies' build tools.

On Wed, Jun 6, 2018 at 2:42 PM Ted Yu <yuzhihong@xxxxxxxxx> wrote:
+1 on this effort

-------- Original message --------
From: Chamikara Jayalath <chamikara@xxxxxxxxxx>
Date: 6/6/18 2:09 PM (GMT-08:00)
Subject: Re: [DISCUSS] [BEAM-4126] Deleting Maven build files (pom.xml) grace period?

+1 for the overall effort. As Pablo mentioned, we need some time to migrate internal Dataflow build off of Maven build files. I created https://issues.apache.org/jira/browse/BEAM-4512 for this.


On Wed, Jun 6, 2018 at 1:30 PM Eugene Kirpichov <kirpichov@xxxxxxxxxx> wrote:
Is it possible for Dataflow to just keep a copy of the pom.xmls and delete it as soon as Dataflow is migrated?

Overall +1, I've been using Gradle without issues for a while and almost forgot pom.xml's still existed.

On Wed, Jun 6, 2018, 1:13 PM Pablo Estrada <pabloem@xxxxxxxxxx> wrote:
I agree that we should delete the pom.xml files soon, as they create a burden for maintainers. 

I'd like to be able to extend the grace period by a bit, to allow the internal build systems at Google to move away from using the Beam poms.

We use these pom files to build Dataflow workers, and thus it's critical for us that they are available for a few more weeks while we set up a gradle build. Perhaps 4 weeks? 
(Calling out+Chamikara Jayalath who has recently worked on internal Dataflow tooling.)


On Wed, Jun 6, 2018 at 1:05 PM Lukasz Cwik <lcwik@xxxxxxxxxx> wrote:
Note: Apache Beam will still provide pom.xml for each release it produces. This is only about people using Maven to build Apache Beam themselves and not relying on the released artifacts in Maven Central.

With the first release using Gradle as the build system is underway, I wanted to start this thread to remind people that we are going to delete the Maven pom.xml files after the 2.5.0 release is finalized plus a two week grace period.

Are there others who would like a shorter/longer grace period?

The PR to delete the pom.xml is here: https://github.com/apache/beam/pull/5571
Got feedback? go/pabloem-feedback