OSDir


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Review Request 66928: Data Migration: Import: Infer Types that Store Edge Ids


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66928/
-----------------------------------------------------------

(Updated May 3, 2018, 5:39 a.m.)


Review request for atlas, Madhan Neethiraj and Ruchi Solani.


Changes
-------

Updates include:
- Refactored _AtlasGraphSONReader.Builder.setDefaults_.


Bugs: ATLAS-2637
    https://issues.apache.org/jira/browse/ATLAS-2637


Repository: atlas


Description
-------

**Approach**
New class: _TypesStoringEdgeIds_: Navigates through all the types in the _typeRegistry_, returns map of entity type and properties that store edge ids.
Modified: _DataMigrationService_: Uses output from class above and passes it down to migration.
Modified: _PostProcessManager_: Uses the map generated above and uses it for post processing.
Modified: _GraphSONUtility_: Improvement to check for vertex of type. This avoids potential exeception when a non-existent property is checked for presence.


Diffs (updated)
-----

  graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraph.java 607baf664 
  graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java c0b9c1741 
  graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java 86cd29900 
  graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/AtlasGraphSONReader.java aa0b6375d 
  graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/GraphSONUtility.java ec320b03e 
  graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/PostProcessManager.java d0a65f7b1 
  graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/migration/GraphSONUtilityPostProcessTest.java 4d73c78ef 
  graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Graph.java d191b5549 
  intg/src/main/java/org/apache/atlas/store/AtlasTypeDefStore.java b05754f4b 
  repository/src/main/java/org/apache/atlas/repository/migration/DataMigrationService.java 22cd55217 
  repository/src/main/java/org/apache/atlas/repository/migration/TypesStoringEdgeIds.java PRE-CREATION 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java 3c84e3c22 
  repository/src/test/java/org/apache/atlas/repository/migration/MigrationBaseAsserts.java ec6e64a25 
  repository/src/test/java/org/apache/atlas/repository/migration/TypesStoringEdgeIdsTest.java PRE-CREATION 


Diff: https://reviews.apache.org/r/66928/diff/2/

Changes: https://reviews.apache.org/r/66928/diff/1-2/


Testing
-------

**Unit tests**

Additional tests added.

**Functional tests**

Regular flow verified.


Thanks,

Ashutosh Mestry