osdir.com

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Reviewing PRs (was: Re: Arrow sync call)


+1 on adding labels for languages, review states, components, etc. This
makes it much easier to filter PRs.

Chao

On Wed, Dec 12, 2018 at 11:54 AM Krisztián Szűcs <szucs.krisztian@xxxxxxxxx>
wrote:

> Create a new one and set arrow-xxx as parent:
> [image: image.png]
>
> On Wed, Dec 12, 2018 at 7:46 PM Antoine Pitrou <antoine@xxxxxxxxxx> wrote:
>
>>
>> Apparently it's possible to create GitHub teams inside the Apache
>> organization ourselves.  I've just created a dummy one:
>> https://github.com/orgs/apache/teams/arrow-xxx/members
>>
>> However, I cannot create a child team inside of the arrow-committers
>> team.  The button "Add a team" here is grayed out:
>> https://github.com/orgs/apache/teams/arrow-committers/teams
>>
>> Regards
>>
>> Antoine.
>>
>>
>> Le 12/12/2018 à 19:40, Krisztián Szűcs a écrit :
>> > I like the GitHub teams approach. Do We need to ask INFRA to create
>> them?
>> >
>> > On Wed, Dec 12, 2018, 7:28 PM Sebastien Binet <binet@xxxxxxx wrote:
>> >
>> >> On Wed, Dec 12, 2018 at 7:25 PM Antoine Pitrou <antoine@xxxxxxxxxx>
>> wrote:
>> >>
>> >>>
>> >>> Hi,
>> >>>
>> >>> Now that we have a lot of different implementations and a growing
>> number
>> >>> of assorted topics, it becomes hard to know whether a PR or issue has
>> a
>> >>> dedicated expert or would benefit from an outsider look.
>> >>>
>> >>> In Python we have what we call the "experts" list which is a per-topic
>> >>> (or per-library module) contributors who are generally interested in
>> and
>> >>> competent on such topic (*).  So it's possible to cc such a person, or
>> >>> if no expert is available on a given topic, perhaps for someone else
>> to
>> >>> try and have a look anyway.  Perhaps we need something similar for
>> Arrow?
>> >>>
>> >>
>> >> with github, one can also create "teams" and "@" them.
>> >> we could perhaps create @arrow-py, @arrow-cxx, @arrow-go, ...
>> >> this dilutes a bit responsibilities but also reduces a bit the net
>> that's
>> >> cast.
>> >>
>> >> -s
>> >>
>> >>
>> >>> (*) https://devguide.python.org/experts/
>> >>>
>> >>> Regards
>> >>>
>> >>> Antoine.
>> >>>
>> >>>
>> >>>
>> >>> Le 12/12/2018 à 19:13, Ravindra Pindikura a écrit :
>> >>>> Attendees : Wes, Sidd, Bryan, Francois, Hatem, Nick, Shyam, Ravindra,
>> >>> Matt
>> >>>>
>> >>>> Wes:
>> >>>> - do not rush the 0.12 release before the holidays, instead target
>> the
>> >>> release for early next year
>> >>>> - request everyone to look at PRs in the queue, and help by doing
>> >> reviews
>> >>>>
>> >>>> Wes/Nick
>> >>>> - queried about Interest in developing a "dataset abstraction" as a
>> >>> layer above file readers that arrow now supports (parquet, csv, json)
>> >>>>
>> >>>> Sidd
>> >>>> - agreed to be the release manager for 0.12
>> >>>> - things to keep in mind for release managers :
>> >>>>  1. We now use crossbow to automate the building of binaries with CI
>> >>>>  2. From this release, the binary artifacts will be hosted in bintray
>> >>> instead of apache dist since the size has increased significantly
>> >>>>
>> >>>> Hatem
>> >>>> - Asked about documentation regarding IDE for setup/debug of arrow
>> >>> libraries
>> >>>> - Wes pointed out the developer wiki on confluence. Hatem offered to
>> >>> help with documentation.
>> >>>>
>> >>>> Thanks and regards,
>> >>>> Ravindra.
>> >>>>
>> >>>> On 2018/12/12 16:54:21, Wes McKinney <w...@xxxxxxxxx> wrote:
>> >>>>> All are welcome to join -- call notes will be posted after>
>> >>>>>
>> >>>>> https://meet.google.com/vtm-teks-phx>
>> >>>
>> >>
>> >
>>
>