osdir.com

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [VOTE] Release Apache Arrow 0.11.0 (RC1)


+1 (binding)

* Ran the source release verification scripts in Ubuntu 14.04 / gcc
4.8.5 (with CMake 3.12 from ppa) and Windows 10 + MSVC 2015 (including
the patch ARROW-2337, just merged)
* Verified the binaries packages

The rough edges we've run into in the release verification are
unfortunate, but as long as the packages look solid I don't think we
should cut another RC in the interest of getting the new package out
there
On Fri, Oct 5, 2018 at 4:38 AM Kouhei Sutou <kou@xxxxxxxxxxxxxx> wrote:
>
> Hi,
>
> Thanks for verifying!
>
> > - meson: https://gist.github.com/kszucs/d6a47425764dea9ef76d8e69f589241f
>
> I'll look into this later.
>
> "/tmp/arrow-release-verify/install//tmp/arrow-release-verify/install/lib"
> is strange. parquet.pc may be broken...? Can you show your parquet.pc?
>
> > - autotools: https://gist.github.com/kszucs/52291265bc0f35a2e033fb3970795d9d
>
> https://github.com/apache/arrow/pull/2709 will fix this.
>
>
> Thanks,
> --
> kou
>
> In <CAHM19a4VddbipW1iA2ugbvdd_C8HWzAdTSUmQ1sZY0C733d-ow@xxxxxxxxxxxxxx>
>   "Re: [VOTE] Release Apache Arrow 0.11.0 (RC1)" on Fri, 5 Oct 2018 09:35:37 +0200,
>   Krisztián Szűcs <szucs.krisztian@xxxxxxxxx> wrote:
>
> > On OSX mojave I c_glib linking error and the same plasma test error Uwe
> > mentioned.
> >
> > With the verification script:
> > - meson: https://gist.github.com/kszucs/d6a47425764dea9ef76d8e69f589241f
> > - autotools: https://gist.github.com/kszucs/52291265bc0f35a2e033fb3970795d9d
> >
> > When I use CONDA_PREFIX as install prefix for both cpp and c_glib the meson
> > build succeeds.
> >
> > On Thu, Oct 4, 2018 at 11:23 PM Uwe L. Korn <uwelk@xxxxxxxxxx> wrote:
> >
> >> I'm struggling a bit to verify the release with the following issues:
> >>
> >> * CMake is too old on Ubuntu 16.04, gbenchmark needs a newer one. A
> >> workaround here would be to install a newer one with conda. Should we do
> >> that always?
> >> * Java tests fail on Ubuntu 16.04:
> >> https://issues.apache.org/jira/browse/ARROW-3443 Following Jacques'
> >> comment, we should disable/ignore the test for this release.
> >> * Plasma tests fail for me on OSX with the following error:
> >> /var/folders/3j/b8ctc4654q71hd_nqqh8yxc00000gp/T/arrow-0.11.0.XXXXX.Psg69q8j/apache-arrow-0.11.0/cpp/src/plasma/io.cc:136:
> >> Socket pathname is too long.
> >> /var/folders/3j/b8ctc4654q71hd_nqqh8yxc00000gp/T/arrow-0.11.0.XXXXX.Psg69q8j/apache-arrow-0.11.0/cpp/src/plasma/store.cc:900:
> >> Check failed: socket >= 0
> >>
> >> Uwe
> >>
> >> On Thu, Oct 4, 2018, at 12:28 PM, Wes McKinney wrote:
> >> > Can you add your other GPG key to the KEYS file? If it's a trusted key
> >> > that seems OK to me
> >> > On Thu, Oct 4, 2018 at 4:34 AM Kouhei Sutou <kou@xxxxxxxxxxxxxx> wrote:
> >> > >
> >> > > Hi,
> >> > >
> >> > > Oh...
> >> > >
> >> > > I've resign by correct GPG key and replaced .asc files.
> >> > >
> >> > > Can we use this RC? Or should we create one more RC for
> >> > > fixing this .asc problem?
> >> > >
> >> > >
> >> > > Thanks,
> >> > > --
> >> > > kou
> >> > >
> >> > > In <1538639225.4190225.1530323248.542DAD31@xxxxxxxxxxxxxxxxxxxxxxxxxxx
> >> >
> >> > >   "Re: [VOTE] Release Apache Arrow 0.11.0 (RC1)" on Thu, 04 Oct 2018
> >> 09:47:05 +0200,
> >> > >   "Uwe L. Korn" <uwelk@xxxxxxxxxx> wrote:
> >> > >
> >> > > > Hello Kou,
> >> > > >
> >> > > > It seems like you have used a GPG key that is not in the main keys
> >> files:
> >> > > >
> >> > > > ```
> >> > > > + gpg --verify apache-arrow-0.11.0.tar.gz.asc
> >> apache-arrow-0.11.0.tar.gz
> >> > > > gpg: Signature made Thu Oct  4 05:46:23 2018 CEST
> >> > > > gpg:                using DSA key
> >> 7714A383F6F73E2D9828791D17423F641C837F31
> >> > > > gpg: Can't check signature: No public key
> >> > > > ```
> >> > > >
> >> > > > Thus it already aborts for me the archive verification step.
> >> > > >
> >> > > > Uwe
> >> > > >
> >> > > > On Thu, Oct 4, 2018, at 9:02 AM, Kouhei Sutou wrote:
> >> > > >> +1 (binding)
> >> > > >>
> >> > > >> I ran the followings on Debian GNU/Linux sid:
> >> > > >>
> >> > > >>   * ARROW_HAVE_GPU=no dev/release/verify-release-candidate.sh
> >> source 0.11.0 1
> >> > > >>   * dev/release/verify-release-candidate.sh binaries 0.11.0 1
> >> > > >>
> >> > > >> with:
> >> > > >>
> >> > > >>   * gcc version 8.2.0 (Debian 8.2.0-1)
> >> > > >>   * OpenJDK 1.8.0_181
> >> > > >>   * Ruby 2.6.0dev
> >> > > >>   * NodeJS 10.8.0
> >> > > >>
> >> > > >> Note that the verification is failed with ARROW_HAVE_GPU=yes:
> >> > > >>
> >> > > >> --
> >> > > >> pyarrow/tests/
> >> > > >> test_plasma.py::TestPlasmaClient::test_create_with_metadata ERROR [
> >> 81%]
> >> > > >> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> captured stderr
> >> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
> >> > > >>
> >> /tmp/arrow-0.11.0.Y6KZK/apache-arrow-0.11.0/cpp/src/plasma/store.cc:971:
> >> > > >> Allowing the Plasma store to use up to 0.1GB of memory.
> >> > > >> /tmp/arrow-0.11.0.Y6KZK/apache-arrow-0.11.0/cpp/src/plasma/
> >> > > >> store.cc:1001: Starting object store with directory /dev/shm and
> >> huge
> >> > > >> page support disabled
> >> > > >> munmap_chunk(): invalid pointer
> >> > > >> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> traceback
> >> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
> >> > > >>
> >> > > >> self = <pyarrow.tests.test_plasma.TestPlasmaClient object at
> >> > > >> 0x7fc4201ae710>
> >> > > >> test_method = <bound method
> >> TestPlasmaClient.test_create_with_metadata
> >> > > >> of <pyarrow.tests.test_plasma.TestPlasmaClient object at
> >> > > >> 0x7fc4201ae710>>
> >> > > >>
> >> > > >>     def teardown_method(self, test_method):
> >> > > >>         try:
> >> > > >>             # Check that the Plasma store is still alive.
> >> > > >>             assert self.p.poll() is None
> >> > > >>             # Ensure Valgrind and/or coverage have a clean exit
> >> > > >>             # Valgrind misses SIGTERM if it is delivered before the
> >> > > >>             # event loop is ready; this race condition is mitigated
> >> > > >>             # but not solved by time.sleep().
> >> > > >>             if USE_VALGRIND:
> >> > > >>                 time.sleep(1.0)
> >> > > >>             self.p.send_signal(signal.SIGTERM)
> >> > > >>             if sys.version_info >= (3, 3):
> >> > > >>                 self.p.wait(timeout=5)
> >> > > >>             else:
> >> > > >>                 self.p.wait()
> >> > > >> >           assert self.p.returncode == 0
> >> > > >> E           assert -6 == 0
> >> > > >> E            +  where -6 = <subprocess.Popen object at
> >> > > >> 0x7fc4201aef98>.returncode
> >> > > >> E            +    where <subprocess.Popen object at 0x7fc4201aef98>
> >> =
> >> > > >> <pyarrow.tests.test_plasma.TestPlasmaClient object at
> >> 0x7fc4201ae710>.p
> >> > > >>
> >> > > >> pyarrow/tests/test_plasma.py:141: AssertionError
> >> > > >> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> entering PDB
> >> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
> >> > > >> >
> >> /tmp/arrow-0.11.0.Y6KZK/apache-arrow-0.11.0/python/pyarrow/tests/test_plasma.py(141)teardown_method()
> >> > > >> -> assert self.p.returncode == 0
> >> > > >> (Pdb)
> >> > > >> --
> >> > > >>
> >> > > >> My GPU is GeForce GTK 1050Ti.
> >> > > >>
> >> > > >> I don't know much about Plasma and GPU stability but I don't
> >> > > >> think that this is a blocker.
> >> > > >>
> >> > > >>
> >> > > >> Thanks,
> >> > > >> --
> >> > > >> kou
> >> > > >>
> >> > > >> In <20181004.142257.2091714912323248008.kou@xxxxxxxxxxxxxx>
> >> > > >>   "[VOTE] Release Apache Arrow 0.11.0 (RC1)" on Thu, 04 Oct 2018
> >> > > >> 14:22:57 +0900 (JST),
> >> > > >>   Kouhei Sutou <kou@xxxxxxxxxxxxxx> wrote:
> >> > > >>
> >> > > >> > Hi,
> >> > > >> >
> >> > > >> > I'd like to propose the 1st release candidate (rc1) of
> >> > > >> > Apache Arrow version 0.11.0 (rc0 is never voted on due to
> >> > > >> > problems I discovered while releasing). This is a major
> >> > > >> > release consisting of 283 resolved JIRAs [1].
> >> > > >> >
> >> > > >> > The source release rc1 is hosted at [2].
> >> > > >> >
> >> > > >> > This release candidate is based on commit
> >> > > >> > 18a61f6758767169a35745f8646991ed245d5a82 [3]
> >> > > >> >
> >> > > >> > The changelog is located at [4].
> >> > > >> >
> >> > > >> > Please download, verify checksums and signatures, run the unit
> >> tests,
> >> > > >> > and vote on the release.
> >> > > >> >
> >> > > >> > See [5] for how to validate a release candidate.
> >> > > >> >
> >> > > >> > The vote will be open for at least 72 hours.
> >> > > >> >
> >> > > >> > [ ] +1 Release this as Apache Arrow 0.11.0
> >> > > >> > [ ] +0
> >> > > >> > [ ] -1 Do not release this as Apache Arrow 0.11.0 because...
> >> > > >> >
> >> > > >> >
> >> > > >> > Thanks,
> >> > > >> > --
> >> > > >> > kou
> >> > > >> >
> >> > > >> > [1]:
> >> > > >> >
> >> https://issues.apache.org/jira/issues/?jql=project%20%3D%20ARROW%20AND%20status%20in%20(Resolved%2C%20Closed)%20AND%20fixVersion%20%3D%200.11.0
> >> > > >> > [2]:
> >> https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-0.11.0-rc1/
> >> > > >> > [3]:
> >> https://github.com/apache/arrow/commit/18a61f6758767169a35745f8646991ed245d5a82
> >> > > >> > [4]:
> >> https://github.com/apache/arrow/blob/7940ffe559810fec82cb2fbb0b13f5809cb5fe85/CHANGELOG.md
> >> > > >> > [5]:
> >> https://cwiki.apache.org/confluence/display/ARROW/How+to+Verify+Release+Candidates
> >>