osdir.com


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[jira] [Created] (ARROW-3242) [C++] Use coarser-grained dispatch to SIMD hash functions


Wes McKinney created ARROW-3242:
-----------------------------------

             Summary: [C++] Use coarser-grained dispatch to SIMD hash functions
                 Key: ARROW-3242
                 URL: https://issues.apache.org/jira/browse/ARROW-3242
             Project: Apache Arrow
          Issue Type: Improvement
          Components: C++
            Reporter: Wes McKinney
             Fix For: 0.11.0


The way that we dispatch to SSE4 hash functions is a remnant from the Impala codebase, which checks CpuInfo on every iteration in debug builds:

https://github.com/apache/arrow/blob/master/cpp/src/arrow/util/hash-util.h#L43

However, the static {{model_name_}} member is causing some non-determinism related to static member lifetime as reported in ARROW-3241. 

I'm proposing to refactor CpuInfo into a singleton pattern and handle SIMD vs non-SIMD dispatch at a higher level rather than at the lowest level like it is now. This should hopefully make the issue in ARROW-3241 go away



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)